You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(maybe) Move peace_rt_model_core::params::* to peace_cmd::params
rt_model_core seems like a catch all crate. Currently params reside in there because they were initially created there, and WorkspaceInitializer from rt_model_native and rt_model_web have functions to serialize them. Perhaps we don't need the parameters for serialization to be strongly typed.
(maybe) Differentiate between StateCurrentDiffs and StateSavedDiffs.
StateDiffs can be computed between StatesDesired - StatesCurrent, or StatesDesired - StatesSaved.
Some outstanding code clean up:
Collapse
StateTypeRegs
intoStateTypeReg
.Previously the serialized types for current state and desired states were different -- current state used
State<Logical, Physical>
, and desired state used justLogical
. This was consolidated in Use singleState
associated type in item spec #69 and Consolidate logical and physical state inItemSpec
. #70.(maybe) Move
peace_rt_model_core::params::*
topeace_cmd::params
rt_model_core
seems like a catch all crate. Currently params reside in there because they were initially created there, andWorkspaceInitializer
fromrt_model_native
andrt_model_web
have functions to serialize them. Perhaps we don't need the parameters for serialization to be strongly typed.(maybe) Differentiate between
StateCurrentDiffs
andStateSavedDiffs
.StateDiffs
can be computed betweenStatesDesired - StatesCurrent
, orStatesDesired - StatesSaved
.If Check that
StatesSaved
matchesStatesCurrent
before runningEnsureCmd::exec
/CleanCmd::exec
#86 is implemented, perhaps we don't have to do this.The text was updated successfully, but these errors were encountered: