Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Maintenance / Simplification #87

Closed
1 of 3 tasks
azriel91 opened this issue Mar 5, 2023 · 1 comment
Closed
1 of 3 tasks

Code Maintenance / Simplification #87

azriel91 opened this issue Mar 5, 2023 · 1 comment

Comments

@azriel91
Copy link
Owner

azriel91 commented Mar 5, 2023

Some outstanding code clean up:

  • Collapse StateTypeRegs into StateTypeReg.

    Previously the serialized types for current state and desired states were different -- current state used State<Logical, Physical>, and desired state used just Logical. This was consolidated in Use single State associated type in item spec #69 and Consolidate logical and physical state in ItemSpec. #70.

  • (maybe) Move peace_rt_model_core::params::* to peace_cmd::params

    rt_model_core seems like a catch all crate. Currently params reside in there because they were initially created there, and WorkspaceInitializer from rt_model_native and rt_model_web have functions to serialize them. Perhaps we don't need the parameters for serialization to be strongly typed.

  • (maybe) Differentiate between StateCurrentDiffs and StateSavedDiffs.

    StateDiffs can be computed between StatesDesired - StatesCurrent, or StatesDesired - StatesSaved.

    If Check that StatesSaved matches StatesCurrent before running EnsureCmd::exec / CleanCmd::exec #86 is implemented, perhaps we don't have to do this.

@azriel91
Copy link
Owner Author

Closing: remaining work hasn't been something impeding development for considerable duration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant