Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure check style in the project #42

Closed
otaviojava opened this issue May 7, 2018 · 3 comments
Closed

Configure check style in the project #42

otaviojava opened this issue May 7, 2018 · 3 comments

Comments

@otaviojava
Copy link
Contributor

Does make sense a PR with check style in the project?

This way, the project will easier to more person contribute and also to maintain the project, I believe that we could start with:

  • number of characts in a line
  • standard to Java class and method
  • Make the header license mandatory
  • Unused imports

Ref: http://checkstyle.sourceforge.net/

@moderakh
Copy link
Contributor

moderakh commented May 8, 2018

@otaviojava thanks. This was one of the things that we had in our backlog queue, we haven't got into doing it yet.

It would help to have some validation on checkstyle integrated in the maven pom file.
Let's start with maven integration and not do any code change into the existing java breaking the codestyle validation for now.

Your PR for integrating this code style validation to maven pom file is welcomed. :-)

@otaviojava
Copy link
Contributor Author

Ok, I'll open a PR soon

@christopheranderson
Copy link
Contributor

Closing old issues. (Still a good idea!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants