Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka trigger parameterization issues #465

Open
nachoge opened this issue Nov 13, 2023 · 2 comments
Open

Kafka trigger parameterization issues #465

nachoge opened this issue Nov 13, 2023 · 2 comments

Comments

@nachoge
Copy link

nachoge commented Nov 13, 2023

Hello,

We've been using Kafka triggers for a long time. We have never had to have a different environment-based parameterization for any of the enum values. Right now we need to have different ones for BrokerProtocol.

Development should be BrokerProtocol.SASLPLAINTEXT
while Production should be BrokerProtocol.SASLSSL

Brokers can be parameterized!

I'm not able to find any way to achieve that! Is there a way? which one -without having to refactor source code on build time a k a: code replacements-

To me seems very limiting not to be able to parameterize ALL OF THEM. Am I missing something?

Using a Constant Class defining
public static final BrokerProtocol BUILD_KAFKA_BROKERS_PROTOCOL_PLAIN=BrokerProtocol.SASLPLAINTEXT;
is neither an option in order to made code replacements -ugly- but in a centralized place

Thanks in advance

@KafkaTrigger(
name = String,
topic = String,
brokerList=String,
protocol=BrokerProtocol <---------------------------- NOT Parameretizable!
consumerGroup=String,
username=String,
password=String,
dataType=String,
authenticationMode=BrokerAuthenticationMode, <---------------------------- NOT Parameretizable!
cardinality=Cardinality, <---------------------------- NOT Parameretizable!
sslCertificateLocation=String,
sslCaLocation=String
)

@muleycharge
Copy link

Related to #389

Does anybody have any work arounds for this? AuthenticationMode, and Protocol vary in our application across environments and trying to figure out how to get around this. Also, Dev envs have an empty value for Password, Username, SchemaRegistryUsername, and SchemaRegistryPassword which makes the library throw an error instead of just ignoring those settings.

@frenchyjef
Copy link

Same here... we want to parametrize these values in our app.settings.json because the values are different between environments we deploy to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants