HTTPSClient::connected() hang when _sslClient is NULL

[yaweiw]

uint8_t HTTPSClient::connected()
{
return _sslClient->connected();
}
when _sslClient is null, HTTPSClient::connected() hangs indefinitely. This doesn't seem right. Can we have some notification via e.g. serial port rather than completely unresponsive?

[sandeepmistry]

Hi @yaweiw,

We can definitely add a NULL check for prevent it crashing. Could you please share an example sketch and steps to reproduce the issue. I'm curious as to how you are encountering this issue.

uint8_t HTTPSClient::connected()
{
  return (_sslClient ? _sslClient->connected() : false);
}

[yaweiw]

@sandeepmistry it can easily be reproduced by not having below lines in your ino file.
Adafruit_WINC1500SSLClient sslClient;
AzureIoTHubClient iotHubClient(sslClient);

[sandeepmistry]

I think a better fix is changing HTTPAPI_Init in src/httpapi.cpp to fail the SSL client is NULL and logging an error.

Would you have time to submit a PR for this?

[yaweiw]

@sandeepmistry Ok. I'll have a look later.

[sandeepmistry]

Closed via #24.