Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP Support in C# PCL #26

Closed
tameraw opened this issue Jan 10, 2017 · 11 comments
Closed

AMQP Support in C# PCL #26

tameraw opened this issue Jan 10, 2017 · 11 comments
Assignees
Labels
enhancement New feature or request.

Comments

@tameraw
Copy link
Contributor

tameraw commented Jan 10, 2017

From @vslepakov on April 13, 2016 7:9

Great to see that there is now a PCL for C#. Are us guys plan on supporting AMQP in this PCL? As far as I know only HTTP is possible now.

Copied from original issue: Azure/azure-iot-sdks#477

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @arturl on April 13, 2016 20:32

Hi @vslepakov, this is on our backlog. We also welcome contributions, if you want to help out on this!

@tameraw tameraw added the enhancement New feature or request. label Jan 10, 2017
@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @vslepakov on April 13, 2016 20:39

Hi @arturl thanks, I might do just that

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @djcasey on September 29, 2016 3:44

Any advance on this?

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @arturl on September 29, 2016 17:38

Hi @vslepakov,
We've added AMQP support for Android -- it will show up in the next release.
Every platform in PCL has to have a different implementation, which is why it will yet be immediately available everywhere.

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @djcasey on September 30, 2016 1:6

Hi @arturl,
When is the next release expected?

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @arturl on September 30, 2016 17:36

Hi @djcasey, new releases come out every couple of weeks, so I expect this to come out very soon. I'll contact the dev team and make sure they include the updated AMQP library in the next release (that's the component that has the fix).

Also note that the PCL NuGet package is no longer needed, the "regular" Azure.Devices.Client NuGet package now supports PCL.

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @djcasey on October 28, 2016 2:45

Hi @arturl, has this feature been delayed? A new version (1.0.21) was released but doesn't appear to support AMQP on Android yet.

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

From @arturl on October 28, 2016 2:57

Yes, this is delayed sorry. @olivierbloch, care to comment on this?
I'll keep the issue open so it stays on the radar.

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

@arturl - A new package for AMQP has been released in NuGet.

@tameraw
Copy link
Contributor Author

tameraw commented Jan 10, 2017

Work is in progress to bring this support in the client SDK.

@arturl
Copy link
Contributor

arturl commented Feb 11, 2017

This is now supported in 1.2.3 version. (To be clear: AMQP on Android only, not universally for PCL)

@arturl arturl closed this as completed Feb 11, 2017
varunpuranik pushed a commit to varunpuranik/azure-iot-sdk-csharp that referenced this issue Dec 13, 2018
The Windows `iotedged` install script updates the caller's system PATH using `SETX /M PATH "$env:Path"`. This is problematic because `$env:Path` is an aggregation of system _and user_ paths, so the command appends more than was intended; the resulting **system** PATH ends up looking like this: `<old system PATH>;<user-local PATH>;C:\ProgramData\iotedge`.

This change updates the script to surgically target the system path in the registry rather than using `SETX`.
brycewang-microsoft pushed a commit that referenced this issue Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants