Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest.IngestionMappingRef should define the default data type #119

Closed
0xThiebaut opened this issue Oct 2, 2022 · 1 comment · Fixed by #136
Closed

ingest.IngestionMappingRef should define the default data type #119

0xThiebaut opened this issue Oct 2, 2022 · 1 comment · Fixed by #136
Labels
enhancement New feature or request

Comments

@0xThiebaut
Copy link

When ingesting data using the ingest.IngestionMappingRef option, the mapping's data type should be used as default data type instead of CSV.

As an example, relying on the ingest.IngestionMappingRef("ExampleMapping", ingest.JSON) option should change the default data type from CSV to JSON, resulting in the ingest.IngestionMappingRef not relying on another ingest.FileFormat option.

It felt counter-intuitive to specify the format twice.

@yogilad yogilad added the enhancement New feature or request label Oct 18, 2022
@AsafMah
Copy link
Contributor

AsafMah commented Nov 21, 2022

Fixed in 0.9.1, if you have further issues please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants