You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
The service_code has several public methods that take a single *p parameter, to allow overloading parameters:
_rule_args takes (topic_name, subscription_name, rule_name) as strings, or (rule) a object with those properties, and an options instance.
_subscription_args takes (topic_name, subscription_name) as strings, or (subscription) a object with those properties, and an options instance.
This is convenient in some circumstances, but I worry about how it is inconsistent. I would expect one of the following:
All methods take a fixed list of parameters, with no overloads.
All methods that take parts of existing classes as inputs also take those classes as inputs in place of the individual parts.
Currently, we have a mix, at least 90% in case 1, and just a few in case 2. This makes it hard to reason about how to use the API.
Suggestions, in order of my preference:
Remove the overloads for Service Bus methods, for consistency.with the rest of the Blob, Queue, and Table APIs. After shipping, we can figure out how to consistently add overloads.
Leave as is.
Add overloads everywhere now, before shipping. (But this is crazy.)
The text was updated successfully, but these errors were encountered:
For example, you could overload the deleteMessage and unlockMessage to accept a message in addition (queue, sequence_number, lock_token) / (topic, subscription, sequence _number, lock_token)
The service_code has several public methods that take a single
*p
parameter, to allow overloading parameters:_rule_args
takes (topic_name, subscription_name, rule_name) as strings, or (rule) a object with those properties, and an options instance._subscription_args
takes (topic_name, subscription_name) as strings, or (subscription) a object with those properties, and an options instance.This is convenient in some circumstances, but I worry about how it is inconsistent. I would expect one of the following:
Currently, we have a mix, at least 90% in case 1, and just a few in case 2. This makes it hard to reason about how to use the API.
Suggestions, in order of my preference:
The text was updated successfully, but these errors were encountered: