Fix to protect against a Json.NET bug

[JamesNK]

Hi

There is a bug in Json.NET that the Windows Azure Storage Client 3.0 is exposed to. Basically if the storage client is run using Json.NET 5.0.4 or earlier it will throw an error when foreaching over an array.

The fix is really simple. Change this line - https://github.com/WindowsAzure/azure-storage-net/blob/c9d52db3f18f971933111f5ba3f7ce4e79927a73/Lib/ClassLibraryCommon/Table/Protocol/TableOperationHttpResponseParsers.cs#L364 - to this:

JToken dataTable = dataSet["value"];

Removing the cast to JArray will stop your library from using the bad GetEnumerator method.

I'm going to fix this bug in Json.NET 6.0. At some point in the future when you upgrade to it you can choose to revert this change if you want.

[JamesNK]

More details about the Json.NET issue if you're interested - http://james.newtonking.com/archive/2013/11/29/fixing-jarray-getenumerator-method-not-found-bug

[jeffwilcox]

Thanks @JamesNK !

[veena-udayabhanu]

Thanks JamesNK. Just to confirm, the client library requires Json .NET 5.0.6 or later. We specify that in the Nuspec. So users downloading our package are forced to reference 5.0.6 or later. So we should not be affected by this issue, correct?

[JamesNK]

The only way a user could run into this bug with the .NET Azure Storage client now is if an older version of Json.NET 5.0 is GACed and that is loaded instead.

I am going to change the JArray.GetEnumerator visibility in Json.NET 6 back to what is what in 5.0.4 (probably early January 2014) and you will need to make this change so Azure Storage works with Json.NET 5 & 6.

When do you plan to release the next version of storage client 3.0?

[veena-udayabhanu]

We are planning to release a hotfix by the end of this week and have included this fix. Thanks again!

[joeg]

This has been resolved in 3.0.1