Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more easily diff-able logs during type generation #103

Closed
anthony-c-martin opened this issue Feb 10, 2021 · 1 comment
Closed

Write more easily diff-able logs during type generation #103

anthony-c-martin opened this issue Feb 10, 2021 · 1 comment
Assignees

Comments

@anthony-c-martin
Copy link
Member

There's no straightforward way to review the logs written during type generation, because versioning and timing is logged, causing a diff in every file (example screenshot below).

We should write the logs in a structured manner - to display the following, so that the PR can be assessed for impact:

  • Added/updated/removed resource types
  • Differences in warnings/errors

We should then be able to generate a summary description for each PR.

image

@jeskew
Copy link
Contributor

jeskew commented Jun 24, 2022

This was partially resolved in #921. The generator's log level will now default to warning, so only warnings, errors, and a brief header will appear in each log file. Unfortunately, that header reports the versions used of both node and the AutoRest CLI, so there's still a bit of work to do.

@jeskew jeskew self-assigned this Jun 24, 2022
@jeskew jeskew closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants