Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to push to testflight: BuildAzurePackages.sh creates a bundle missing "CFBundleVersion" in info.plist AND AzureCommunicationCalling is missing "CFBundleShortVersionString" #41

Closed
tompi opened this issue Oct 1, 2020 · 4 comments
Assignees
Labels
Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK

Comments

@tompi
Copy link

tompi commented Oct 1, 2020

This is not a big problem until you try to bundle the app for distribution.

When trying to upload IPA from build server, I got this:

ERROR ITMS-90056: "This bundle Payload/TCPRLink.iOS.app/Frameworks/AzureCommunication.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion

Added it manually to info.plist of AzureCommunication.framework and AzureCore.framework, and got this:

ERROR ITMS-90057: "The bundle 'Payload/TCPRLink.iOS.app/Frameworks/AzureCommunicationCalling.framework' is missing plist key. The Info.plist file is missing the required key: CFBundleShortVersionString.  

After I added this one as well, I was able to upload the IPA, but got this in a mail:

ITMS-90338: Non-public API usage - The app links to non-public libraries in Frameworks/AzureCommunicationCalling.framework/AzureCommunicationCalling: /System/Library/PrivateFrameworks/IOSurface.framework/IOSurface. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. For further information, visit the Technical Support Information at http://developer.apple.com/support/technical/

Is there a way to get around this last one? (I assume you need to fix the other 2 at your end, in the build scripts)

@RinaRish RinaRish added the Calling Issue involves Calling functionality. label Oct 1, 2020
@tompi
Copy link
Author

tompi commented Oct 2, 2020

@raosanat I suspect this might be because you compiled the framework with MinimumOsVersion=10, while IOSurface is an iOS 11 api. Could you possibly Change MinimumOsVersion to 12(I believe thats minimum version for AzureCore and AzureCommunication?) OR if I could get access or a copy of the source code I could compile it myself... I have a nice POC for iOS now, but having trouble distributing it to other locations when I cant upload to testflight...

@raosanat
Copy link
Member

raosanat commented Oct 2, 2020

Hi @tompi we are working on providing a release which will fix this issue. I will send you the link to the new release by tomorrow.

@raosanat
Copy link
Member

raosanat commented Oct 2, 2020

Hi @tompi sorry for the delay here is the link to the release that will fix your above problem with AzureCommunicationCalling SDK linking to IOSurface framework.

AzureCommunicationCalling- v3.1.100120-prerelease

Please note that you will still have to manually update the info.plist with versions , the fix for this will come in the upcoming release.

@tompi
Copy link
Author

tompi commented Oct 6, 2020

Thnx @raosanat I was able to deploy successfully to testflight now!

@tompi tompi closed this as completed Oct 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2020
@mariusu-msft mariusu-msft added the iOS Issues involving the iOS SDK label Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK
Projects
None yet
Development

No branches or pull requests

4 participants