Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determining Stream Type is inconsistent between LocalVideoStream and RemoteVideoStream #65

Closed
eliaspuurunen opened this issue Oct 15, 2020 · 2 comments
Assignees
Labels
Calling Issue involves Calling functionality. Feature Request New feature or request JavaScript Issues involving the JavaScript SDK Roadmap Issue is resolved by an item on the ACS Roadmap UV

Comments

@eliaspuurunen
Copy link

Is your feature request related to a problem? Please describe.
If a user is working with a LocalVideoStream, they can fetch the type through the method getMediaStreamType().

https://docs.microsoft.com/en-us/javascript/api/azure-communication-services/@azure/communication-calling/localvideostream?view=azure-communication-services-js

If a user is working with a RemoteVideoStream, they can fetch the type through the property type.

https://docs.microsoft.com/en-us/javascript/api/azure-communication-services/@azure/communication-calling/remotevideostream?view=azure-communication-services-js#type

Describe the solution you'd like
Could LocalVideoStream expose a property called type so the developer does not have to have two code paths for dealing with type determination?

@akania
Copy link
Member

akania commented Oct 15, 2020

Hi @eliaspuurunen , thank you for your feedback, that's a good catch and we'll address it in future release.

@mariusu-msft mariusu-msft added Calling Issue involves Calling functionality. Bug Something isn't working labels Oct 15, 2020
@akania akania added Feature Request New feature or request and removed Bug Something isn't working labels Oct 15, 2020
@ProbablePrime ProbablePrime added the Roadmap Issue is resolved by an item on the ACS Roadmap label Oct 30, 2020
@ProbablePrime ProbablePrime added the JavaScript Issues involving the JavaScript SDK label Nov 10, 2020
@akania
Copy link
Member

akania commented Jun 7, 2021

hi @eliaspuurunen , small cleanup - we've introduced 'mediaStreamType' ( in v1.0.0-beta.5 ) - please update to latest version - both remote & local stream have same mediaStreamType property that can be used to determine if stream is 'video' or 'screenshare'

@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Calling Issue involves Calling functionality. Feature Request New feature or request JavaScript Issues involving the JavaScript SDK Roadmap Issue is resolved by an item on the ACS Roadmap UV
Projects
None yet
Development

No branches or pull requests

5 participants