Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentations needed for 2 env variables in updateParameters.yml #36

Closed
abdale opened this issue Apr 20, 2021 · 2 comments · Fixed by #37
Closed

Documentations needed for 2 env variables in updateParameters.yml #36

abdale opened this issue Apr 20, 2021 · 2 comments · Fixed by #37
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@abdale
Copy link
Contributor

abdale commented Apr 20, 2021

These two env variables in the updateParameters.yml are not covered in the documentation:

  ML_COMPUTE_INSTANCE_USER_OBJECT_ID: '{mlComputeInstanceObjectId}'
  DATABRICKS_WORKSPACE_ID: '{databricksWorkspaceId}'

It would be nice to list them in the parameter update process and also the details on where we can find these two.

@abdale abdale added the documentation Improvements or additions to documentation label Apr 20, 2021
@abdale
Copy link
Contributor Author

abdale commented Apr 22, 2021

I couldn't find a ML instance but thanks to @xigyenge I left this one as-is (empty string doesn't work) and it created one.

I think the documentation can also cover that and perhaps a comment in the yml file which says something like:

# If you do not have a ML compute instance, leave this is as-is so one is created for you

Also, for the second one i.e. the databricks workspace, I used the one in the rg {myprefix}-shared-product called {my-prefix}-databricks002-processing. Hoping this is the correct one! :)

@marvinbuss marvinbuss linked a pull request Apr 23, 2021 that will close this issue
@marvinbuss
Copy link
Collaborator

Will be fixed by the PR that is linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants