Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make messages persistent? #11

Closed
lsattem opened this issue Aug 10, 2020 · 2 comments
Closed

How to make messages persistent? #11

lsattem opened this issue Aug 10, 2020 · 2 comments

Comments

@lsattem
Copy link

lsattem commented Aug 10, 2020

Hi! I might have overlooked something, but I'm unable to make new queues/messages persistent. I'm coming from Java where I've been able to create new queues/messages that default to persistent. I've found the 'durability configuration' link option on create sender/receiver, but that does not seem to make messages persistent.

How do I mark my messages as persistent?

Thanks in advance!

@lsattem
Copy link
Author

lsattem commented Aug 10, 2020

Seems if I add the field DeliveryMode to MessageProperties and to the list of fields in unmarshal/marshal I'm able to get persistency. I don't have enough of an overview to know what else must be added to avoid breaking something, though.

@lsattem
Copy link
Author

lsattem commented Aug 11, 2020

Turns out I had misunderstood the documentation/code, and that to make messages persistent I had to set MessageHeader.Durable to 'true'!

@lsattem lsattem closed this as completed Aug 11, 2020
mihaitodor added a commit to redpanda-data/connect that referenced this issue Apr 15, 2024
The `amqp_0_9` has this field already: https://www.benthos.dev/docs/components/outputs/amqp_0_9/#persistent

Implementation inspired from here: Azure/go-amqp#11

This omission was reported on Slack: https://gophers.slack.com/archives/CLWCBK7FY/p1713189832118529

Signed-off-by: Mihai Todor <todormihai@gmail.com>
mihaitodor added a commit to redpanda-data/connect that referenced this issue Apr 15, 2024
The `amqp_0_9` has this field already: https://www.benthos.dev/docs/components/outputs/amqp_0_9/#persistent

Implementation inspired from here: Azure/go-amqp#11

This omission was reported on Slack: https://gophers.slack.com/archives/CLWCBK7FY/p1713189832118529

Signed-off-by: Mihai Todor <todormihai@gmail.com>
mihaitodor added a commit to redpanda-data/connect that referenced this issue Apr 15, 2024
The `amqp_0_9` has this field already: https://www.benthos.dev/docs/components/outputs/amqp_0_9/#persistent

Implementation inspired from here: Azure/go-amqp#11

This omission was reported on Slack: https://gophers.slack.com/archives/CLWCBK7FY/p1713189832118529

Signed-off-by: Mihai Todor <todormihai@gmail.com>
mihaitodor added a commit to redpanda-data/connect that referenced this issue Apr 15, 2024
The `amqp_0_9` has this field already: https://www.benthos.dev/docs/components/outputs/amqp_0_9/#persistent

Implementation inspired from here: Azure/go-amqp#11

This omission was reported on Slack: https://gophers.slack.com/archives/CLWCBK7FY/p1713189832118529

Signed-off-by: Mihai Todor <todormihai@gmail.com>
mihaitodor added a commit to redpanda-data/connect that referenced this issue Apr 16, 2024
The `amqp_0_9` has this field already: https://www.benthos.dev/docs/components/outputs/amqp_0_9/#persistent

Implementation inspired from here: Azure/go-amqp#11

This omission was reported on Slack: https://gophers.slack.com/archives/CLWCBK7FY/p1713189832118529

Signed-off-by: Mihai Todor <todormihai@gmail.com>
wehr503 pushed a commit to uniserv-org/redpanda-data-connect that referenced this issue Apr 19, 2024
The `amqp_0_9` has this field already: https://www.benthos.dev/docs/components/outputs/amqp_0_9/#persistent

Implementation inspired from here: Azure/go-amqp#11

This omission was reported on Slack: https://gophers.slack.com/archives/CLWCBK7FY/p1713189832118529

Signed-off-by: Mihai Todor <todormihai@gmail.com>
Signed-off-by: Stephan Wehr <stephan.wehr@uniserv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant