Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writes to net.Conn need to be deterministic #280

Closed
jhendrixMSFT opened this issue Apr 13, 2023 · 0 comments · Fixed by #282
Closed

Writes to net.Conn need to be deterministic #280

jhendrixMSFT opened this issue Apr 13, 2023 · 0 comments · Fixed by #282
Labels
blocking-release Blocks release

Comments

@jhendrixMSFT
Copy link
Member

Failed writes will terminate the Conn, and while this will terminate all sessions/links, it happens asynchronously so it's not always clear which API call actually failed.

In addition, we should use the context's deadline, when available, as the write timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocking-release Blocks release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make writes deterministic jhendrixMSFT/go-amqp
1 participant
@jhendrixMSFT