Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestIntegrationReceiverModeSecond uncovers races #55

Closed
jhendrixMSFT opened this issue Sep 3, 2021 · 1 comment
Closed

TestIntegrationReceiverModeSecond uncovers races #55

jhendrixMSFT opened this issue Sep 3, 2021 · 1 comment

Comments

@jhendrixMSFT
Copy link
Member 

==================
WARNING: DATA RACE
Write at 0x00c000002458 by goroutine 20:
  github.com/Azure/go-amqp.(*link).muxReceive()
      C:/git/Azure/go-amqp/link.go:542 +0x1334
  github.com/Azure/go-amqp.(*link).muxHandleFrame()
      C:/git/Azure/go-amqp/link.go:567 +0x384
  github.com/Azure/go-amqp.(*link).mux()
      C:/git/Azure/go-amqp/link.go:321 +0xab6
  github.com/Azure/go-amqp.attachLink┬╖dwrap┬╖12()
      C:/git/Azure/go-amqp/link.go:237 +0x39

Previous read at 0x00c000002458 by goroutine 16:
  github.com/Azure/go-amqp.(*Session).mux()
      C:/git/Azure/go-amqp/session.go:362 +0xd84
  github.com/Azure/go-amqp.(*Client).NewSession┬╖dwrap┬╖1()
      C:/git/Azure/go-amqp/client.go:155 +0x47

Goroutine 20 (running) created at:
  github.com/Azure/go-amqp.attachLink()
      C:/git/Azure/go-amqp/link.go:237 +0x174c
  github.com/Azure/go-amqp.(*Session).NewReceiver()
      C:/git/Azure/go-amqp/session.go:90 +0x11e
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2()
      C:/git/Azure/go-amqp/integration_test.go:371 +0x164

Goroutine 16 (running) created at:
  github.com/Azure/go-amqp.(*Client).NewSession()
      C:/git/Azure/go-amqp/client.go:155 +0x6f7
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1()
      C:/git/Azure/go-amqp/integration_test.go:330 +0x1f5
  testing.tRunner()
      C:/Program Files/Go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run┬╖dwrap┬╖21()
      C:/Program Files/Go/src/testing/testing.go:1306 +0x47
==================
==================
WARNING: DATA RACE
Write at 0x00c0000560f0 by goroutine 19:
  github.com/Azure/go-amqp.(*inFlight).add()
      C:/git/Azure/go-amqp/receiver.go:296 +0x135
  github.com/Azure/go-amqp.(*Receiver).messageDisposition()
      C:/git/Azure/go-amqp/receiver.go:259 +0x124
  github.com/Azure/go-amqp.(*Message).Accept()
      C:/git/Azure/go-amqp/types.go:1815 +0x137
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2.1()
      C:/git/Azure/go-amqp/integration_test.go:385 +0x8b
  github.com/Azure/go-amqp.(*Receiver).HandleMessage.func2()
      C:/git/Azure/go-amqp/receiver.go:57 +0x1b7
  github.com/Azure/go-amqp.(*Receiver).HandleMessage()
      C:/git/Azure/go-amqp/receiver.go:75 +0x5ad
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2()
      C:/git/Azure/go-amqp/integration_test.go:383 +0x3d2

Previous read at 0x00c0000560f0 by goroutine 20:
  github.com/Azure/go-amqp.(*link).mux()
      C:/git/Azure/go-amqp/link.go:314 +0x224
  github.com/Azure/go-amqp.attachLink┬╖dwrap┬╖12()
      C:/git/Azure/go-amqp/link.go:237 +0x39

Goroutine 19 (running) created at:
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1()
      C:/git/Azure/go-amqp/integration_test.go:367 +0xa64
  testing.tRunner()
      C:/Program Files/Go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run┬╖dwrap┬╖21()
      C:/Program Files/Go/src/testing/testing.go:1306 +0x47

Goroutine 20 (running) created at:
  github.com/Azure/go-amqp.attachLink()
      C:/git/Azure/go-amqp/link.go:237 +0x174c
  github.com/Azure/go-amqp.(*Session).NewReceiver()
      C:/git/Azure/go-amqp/session.go:90 +0x11e
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2()
      C:/git/Azure/go-amqp/integration_test.go:371 +0x164
==================
==================
WARNING: DATA RACE
Read at 0x00c0001173f0 by goroutine 19:
  github.com/Azure/go-amqp.(*Message).done()
      C:/git/Azure/go-amqp/types.go:1786 +0x3c
  github.com/Azure/go-amqp.(*Message).Accept┬╖dwrap┬╖20()
      C:/git/Azure/go-amqp/types.go:1814 +0x39
  github.com/Azure/go-amqp.(*Message).Accept()
      C:/git/Azure/go-amqp/types.go:1815 +0x148
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2.1()
      C:/git/Azure/go-amqp/integration_test.go:385 +0x8b
  github.com/Azure/go-amqp.(*Receiver).HandleMessage.func2()
      C:/git/Azure/go-amqp/receiver.go:57 +0x1b7
  github.com/Azure/go-amqp.(*Receiver).HandleMessage()
      C:/git/Azure/go-amqp/receiver.go:75 +0x5ad
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2()
      C:/git/Azure/go-amqp/integration_test.go:383 +0x3d2

Previous write at 0x00c0001173f0 by goroutine 21:
  github.com/Azure/go-amqp.(*Receiver).HandleMessage.func1()
      C:/git/Azure/go-amqp/receiver.go:35 +0x73
  github.com/Azure/go-amqp.(*Receiver).HandleMessage.func2┬╖dwrap┬╖14()
      C:/git/Azure/go-amqp/receiver.go:54 +0x47

Goroutine 19 (running) created at:
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1()
      C:/git/Azure/go-amqp/integration_test.go:367 +0xa64
  testing.tRunner()
      C:/Program Files/Go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run┬╖dwrap┬╖21()
      C:/Program Files/Go/src/testing/testing.go:1306 +0x47

Goroutine 21 (running) created at:
  github.com/Azure/go-amqp.(*Receiver).HandleMessage.func2()
      C:/git/Azure/go-amqp/receiver.go:54 +0x1a5
  github.com/Azure/go-amqp.(*Receiver).HandleMessage()
      C:/git/Azure/go-amqp/receiver.go:75 +0x5ad
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2()
      C:/git/Azure/go-amqp/integration_test.go:383 +0x3d2
==================
==================
WARNING: DATA RACE
Write at 0x00c00013b650 by goroutine 19:
  runtime.mapassign_fast32()
      C:/Program Files/Go/src/runtime/map_fast32.go:92 +0x0
  github.com/Azure/go-amqp.(*inFlight).add()
      C:/git/Azure/go-amqp/receiver.go:298 +0x93
  github.com/Azure/go-amqp.(*Receiver).messageDisposition()
      C:/git/Azure/go-amqp/receiver.go:259 +0x124
  github.com/Azure/go-amqp.(*Message).Accept()
      C:/git/Azure/go-amqp/types.go:1815 +0x137
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2.1()
      C:/git/Azure/go-amqp/integration_test.go:385 +0x8b
  github.com/Azure/go-amqp.(*Receiver).HandleMessage.func2()
      C:/git/Azure/go-amqp/receiver.go:57 +0x1b7
  github.com/Azure/go-amqp.(*Receiver).HandleMessage()
      C:/git/Azure/go-amqp/receiver.go:75 +0x5ad
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2()
      C:/git/Azure/go-amqp/integration_test.go:383 +0x3d2

Previous read at 0x00c00013b650 by goroutine 20:
  github.com/Azure/go-amqp.(*link).mux()
      C:/git/Azure/go-amqp/link.go:314 +0x244
  github.com/Azure/go-amqp.attachLink┬╖dwrap┬╖12()
      C:/git/Azure/go-amqp/link.go:237 +0x39

Goroutine 19 (running) created at:
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1()
      C:/git/Azure/go-amqp/integration_test.go:367 +0xa64
  testing.tRunner()
      C:/Program Files/Go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run┬╖dwrap┬╖21()
      C:/Program Files/Go/src/testing/testing.go:1306 +0x47

Goroutine 20 (running) created at:
  github.com/Azure/go-amqp.attachLink()
      C:/git/Azure/go-amqp/link.go:237 +0x174c
  github.com/Azure/go-amqp.(*Session).NewReceiver()
      C:/git/Azure/go-amqp/session.go:90 +0x11e
  github.com/Azure/go-amqp_test.TestIntegrationReceiverModeSecond.func1.2()
      C:/git/Azure/go-amqp/integration_test.go:371 +0x164
==================
@jhendrixMSFT jhendrixMSFT mentioned this issue Sep 3, 2021
Merged
@jhendrixMSFT
Copy link
Member Author

Fixed in v0.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhendrixMSFT