-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add additional tags in reservation #84
Comments
Hello @XtratusCloud, thanks so much for submitting this feature request! First and foremost, I love this and I'm happy to incorporate this into Azure IPAM. Couple of things:
Do you think an arbitrary dictionary of key/value pairs makes sense here? What type of data are YOU using this for, and could those same purposes be applied to other users (e.g. is this only a description, or is there something else that is important here)? Very much appreciate the feedback and I'm quite sure we can get this folded in right away. Let's just make sure we're thinking through the proposed structure and it's intended use cases together. Thanks! |
Hi @DCMattyG , thanks for your quick response. Totally agree about using the term "metadata" instead of "tags", Basically what we need is a simple description, which could be achieved by adding a simple text field. Totally agree that displaying a tooltip on a floating window is not the most stylish and practical UI implementation ;) Thanks!! |
Thanks for the feedback @XtratusCloud! In that case does it make sense just to add an optional description field to the API, or is there a need where a number of key/value pairs would need to be appended? |
Hi @DCMattyG , Thanks!! |
I have tested the existing implementation in the "vwan-support" branch, which allows you to specify a description when creating a reservation, and it covers our needs perfectly. @DCMattyG , this request can be closed at your convenience. |
Hi @XtratusCloud, this is now completed and had been merged into main via PR #113. Thank you for all of your support in bringing this feature into Azure IPAM! |
Is your feature request related to a problem? Please describe.
In our organization the number of pending reservations starts to be high, and the list displayed leaves no evidence of the project or architecture for which it has been requested.
Describe the solution you'd like
Allow to include additional tags when creating the reservation via API, and display this tags in the UI in one additional column
Additional context
We currently have it already implemented in the following commit (in our repository),
XtratusCloud@de57542
which includes the following:
Allow to add "tags" in the boyd of POST reservation request to API
Manage the tag content in the reservation class, in models:
And finally, add an additional column in UI, in the reservation windows, to display the tags.
The text was updated successfully, but these errors were encountered: