Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support re-deploy k8s job. #285

Open
victorchen2022 opened this issue May 10, 2023 · 4 comments
Open

Feature Request: support re-deploy k8s job. #285

victorchen2022 opened this issue May 10, 2023 · 4 comments
Labels
idle Inactive for 14 days

Comments

@victorchen2022
Copy link

Feature request

I hope k8s-deploy action can support k8s job deploy repeatedly.
because in normal situation, github actions will report error because of k8s job is immuteable so that we
have to delete it first.

@victorchen2022 victorchen2022 changed the title Feature Request: Feature Request: support re-deploy k8s job. May 10, 2023
@OliverMKing
Copy link
Collaborator

OliverMKing commented May 11, 2023

Can you provide the error that k8s-deploy gives when running repeatedly? k8s-deploy internally uses kubectl apply so it should be idempotent.

@victorchen2022
Copy link
Author

victorchen2022 commented May 12, 2023 via email

@OliverMKing
Copy link
Collaborator

it's just like what https://stackoverflow.com/questions/56264165/field-is-immutable-k8s describe.

On Fri, May 12, 2023 at 1:28 AM Oliver King @.> wrote: Can you provide the error that k8s-deploy gives when running repeatedly? — Reply to this email directly, view it on GitHub <#285 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7MPKFG5EYQFDGCW6V7A7TXFUOU7ANCNFSM6AAAAAAX4MPMTU . You are receiving this because you authored the thread.Message ID: @.>

All k8s tools I'm aware of follow the same approach that k8s-deploy used here. The stackoverflow link's solution is to delete the overlapping deployment. I'm not sure what a good way for k8s-deploy to do that would be. Deleting a resource is an extremely destructive action.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days
Projects
None yet
Development

No branches or pull requests

2 participants