Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "commandToExecute" in all *config.json to "protectedSettings" #37

Closed
hosungsmsft opened this issue Feb 8, 2018 · 0 comments
Closed

Move "commandToExecute" in all *config.json to "protectedSettings" #37

hosungsmsft opened this issue Feb 8, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.

Comments

@hosungsmsft
Copy link

"commandToExecute" contains secrets (passwords) and shouldn't be in the "settings" (plaintext), but placed in the "protectedSettings". See this (the Note at the bottom).
@hosungsmsft hosungsmsft added bug Something isn't working good first issue Good for newcomers Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP. labels Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hosungsmsft