Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'skufamily; parameter from azuredeploy.json #54

Closed
SorraTheOrc opened this issue Mar 17, 2018 · 2 comments · Fixed by #58
Closed

Remove 'skufamily; parameter from azuredeploy.json #54

SorraTheOrc opened this issue Mar 17, 2018 · 2 comments · Fixed by #58
Labels
enhancement New feature or request good first issue Good for newcomers Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.

Comments

@SorraTheOrc
Copy link
Contributor

It's late so I don't want to do this now incase I'm missing something, but it looks to me like we can remove some parameters from azuredeploy.json. @hosungsmsft please review the below:

skufamily appears only in documentation and has meaningless allowed values

$ grep -rnw '.' --include '*.json' -e 'skuFamily'
./azuredeploy.json:257:        "skuFamily": {
./azuredeploy.json:729:            "skuFamily": "[parameters('skuFamily')]",
./nested/mssql.json:50:        "documentation6": " skuFamily                   - Mssql sku family",
./nested/postgres.json:43:                "family": "[parameters('moodleCommon').skuFamily]",
./nested/postgres.json:58:        "documentation6": " skuFamily                   - Postgresql sku family",
./nested/mysql.json:43:                "family": "[parameters('moodleCommon').skuFamily]",
./nested/mysql.json:58:        "documentation6": " skuFamily                   - Mysql sku family",

The only use that looks potentially relevant is ./nested/mysql.json:43 but given that this is not a parameter in the REST API I believe it is not required - https://docs.microsoft.com/en-us/rest/api/mysql/servers/createorupdate#serverpropertiesfordefaultcreate

@SorraTheOrc SorraTheOrc added enhancement New feature or request good first issue Good for newcomers Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP. labels Mar 17, 2018
@hosungsmsft
Copy link

Yes, I observed this as well, and was going to remove this... I was worried if that might cause a regression, but I highly doubt so.

In fact, the overall DB configuration story in our templates is not very great. It's especially true after we introduced MS SQL as well. The MySQL/PostgreSQL SKUs also changed, so that needs to be incorporated. We might need some overall reorg design on DB configs...

@SorraTheOrc
Copy link
Contributor Author

Agreed. Lets remove skufamily.

For the general configuration we could address that as part of #53 which is a general overhaul of all parameter names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants