Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure private dns network links missing secure spoke ids #1106

Closed
paul-e-martin opened this issue Aug 27, 2024 · 0 comments
Closed

Azure private dns network links missing secure spoke ids #1106

paul-e-martin opened this issue Aug 27, 2024 · 0 comments

Comments

@paul-e-martin
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.9.4

azure provider: 3.115.0

module: Connectivity

Description

Describe the bug

Deploying vWAN with private DNS zones, only links to the unsecured virtual networks, not the secured virtual networks

Steps to Reproduce

  1. Create a deployment with vWAN configuration, non-secure and secure spokes, enable Private DNS links
  2. Deploy config, and will see that only the non-secure virtual networks get links created

Screenshots

Additional context

To resolve, update line 1684 of modules/connectivity/locals.tf as per below
from
for spoke_resource_id in virtual_hub_config.config.spoke_virtual_network_resource_ids :
to
for spoke_resource_id in concat(virtual_hub_config.config.spoke_virtual_network_resource_ids, virtual_hub_config.config.secure_spoke_virtual_network_resource_ids) :
@paul-e-martin paul-e-martin mentioned this issue Aug 27, 2024
Merged
5 tasks
matt-FFFFFF pushed a commit that referenced this issue Aug 29, 2024
@paul-e-martin
Updated spoke_virtual_networks_for_dns to include the secure virtual …
05d6e7b 
…network ids (#1107)

#1106
Updated spoke_virtual_networks_for_dns to include the secure virtual
network ids

<!-- markdownlint-disable first-line-h1 -->

<!-- Thank you for submitting a Pull Request. Please fill out the
template below.-->
## Overview/Summary

Replace this with a brief description of what this Pull Request fixes,
changes, etc.

## This PR fixes/adds/changes/removes

1. *Replace me*
2. *Replace me*
3. *Replace me*

### Breaking Changes

1. *Replace me*
2. *Replace me*

## Testing Evidence

Please provide any testing evidence to show that your Pull Request
works/fixes as described and planned (include screenshots, if
appropriate).

## As part of this Pull Request I have

- [ ] Checked for duplicate [Pull
Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls)
- [ ] Associated it with relevant
[issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues),
for tracking and closure.
- [ ] Ensured my code/branch is up-to-date with the latest changes in
the `main`
[branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main)
- [ ] Performed testing and provided evidence.
- [ ] Updated relevant and associated documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paul-e-martin