Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed 2.5.6 changelog contains only changes from 2.5.1 #7

Open
Flamefire opened this issue Mar 4, 2021 · 2 comments
Open

Installed 2.5.6 changelog contains only changes from 2.5.1 #7

Flamefire opened this issue Mar 4, 2021 · 2 comments

Comments

@Flamefire
Copy link

I downloaded and installed vld-2.5.6-setup.exe from the GH releases but the installed changelog does state "Visual Leak Detector (VLD) Version 2.5.1"

Is there a bug in the setup generation?

@mattdurak
Copy link

I see the latest change log with my 2.5.7 install in C:\Program Files (x86)\Visual Leak Detector\CHANGES.txt

Do you still see this issue with 2.5.7? If so, I'm not sure what the issue is, but you are welcome to submit a PR if you see an issue that can be fixed and we will do our best to review and merge it.

You should also check that C:\Program Files (x86)\Visual Leak Detector\bin\Win64\vld_x64.dll has a file version of 2.5.7 (or 2.5.6 for your current install) to make sure it actually installed.

@Flamefire
Copy link
Author

With 2.5.7 I can confirm this is working.

For reference: I've seen this while using a CMake Find module which reads the changes.txt to get the version as the headers don't contain the version (might be worth to add): https://github.com/Return-To-The-Roots/s25client/blob/master/cmake/Modules/FindVLD.cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants