Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Architecture parsing failing on MacOS with coreutils installed through Homebrew #350

Closed
zorfling opened this issue Nov 7, 2023 · 2 comments
Closed

Architecture parsing failing on MacOS with coreutils installed through Homebrew #350

zorfling opened this issue Nov 7, 2023 · 2 comments

Comments

@zorfling
Copy link
Contributor

zorfling commented Nov 7, 2023 •
edited

When trying to install the 1ES DevTool on MacOS and coreutils installed through Homebrew, I'm getting an error installing the azureauth cli that seems related to a bad parsing of uname -a in install.sh

Error obtaining access token: [System.Exception: Error installing azureauth cli. Log: . Error: Unsupported architecture 'Darwin', unable to download a release

Changing from uname -a | rev | cut -d ' ' -f1 | rev to grepping for x86_64 or arm64 seems to work - PR incoming
zorfling added a commit to zorfling/microsoft-authentication-cli that referenced this issue Nov 7, 2023
@zorfling
Refactor release_name function to be more resilient detecting archite…
3924ad7 
…cture on macOS [AzureAD#350]
@zorfling zorfling changed the title Architecture parsing failing on MacOS Ventura 13.6.1 / Macbook Pro M1 Max Architecture parsing failing on MacOS with coreutils installed through Homebrew Nov 7, 2023
@zorfling zorfling mentioned this issue Nov 7, 2023
Closed
@reillysiemens
Copy link
Member

@zorfling, thanks for bringing this to our attention! I should have assumed that uname -a wouldn't output stable columns. Using grep seems like a much safer approach. 👍

reillysiemens pushed a commit that referenced this issue Nov 8, 2023
@zorfling @reillysiemens
Refactor release_name function to be more resilient detecting archite…
f2142f8 
…cture on macOS [#350]
reillysiemens added a commit that referenced this issue Nov 8, 2023
@reillysiemens @zorfling
Refactor release_name function to be more resilient detecting archite…
f81ad81 
…cture on macOS [#350] (#354)

Co-authored-by: Chris Colborne <zorfling@gmail.com>
@reillysiemens
Copy link
Member

Resolved this with #354 (a resubmission of @zorfling's #351).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zorfling @reillysiemens