Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "__enhancd::cd()" arguments "-" and ".." configurable by shell vars #37

Merged
merged 4 commits into from
Aug 29, 2016
Merged

Make "__enhancd::cd()" arguments "-" and ".." configurable by shell vars #37

merged 4 commits into from
Aug 29, 2016

Conversation

key-amb
Copy link
Contributor

@key-amb key-amb commented Jun 25, 2016

Hello,

Summary of This Request

  • Make arguments - or .. for __enhancd::cd() configurable by shell variables ENHANCD_HYPHEN_ARG or ENHANCD_DOT_ARG.
  • Fix problem: __enhancd::cd - did not work when ENHANCD_DISABLE_HYPHEN is set.
  • Add tests for these above.

Motivation

Thank you for this great convenient tool.

But I would be happier if I can use cd - and cd .. as they were before I introduced enhancd.
So, I tried a hack to make these args configurable.

Though this change is for myself, I would be happy if you like it.

P.S.

And thank you for using "shove" for testing!

@babarot
Copy link
Owner

babarot commented Jun 30, 2016

Hi, @key-amb . Thank you for your contribution and I'm so sorry for taking long to write you back.

I got it. Please wait a little because I'll try it out! Thanks.

@babarot babarot merged commit bf068c3 into babarot:master Aug 29, 2016
@babarot
Copy link
Owner

babarot commented Aug 29, 2016

Awesome! Thanks @key-amb and sorry for late reply.

@key-amb key-amb deleted the feature/configure-subcommands branch August 29, 2016 14:19
@key-amb
Copy link
Contributor Author

key-amb commented Aug 29, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants