New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "__enhancd::cd()" arguments "-" and ".." configurable by shell vars #37

Merged
merged 4 commits into from Aug 29, 2016

Conversation

Projects
None yet
2 participants
@key-amb
Contributor

key-amb commented Jun 25, 2016

Hello,

Summary of This Request

  • Make arguments - or .. for __enhancd::cd() configurable by shell variables ENHANCD_HYPHEN_ARG or ENHANCD_DOT_ARG.
  • Fix problem: __enhancd::cd - did not work when ENHANCD_DISABLE_HYPHEN is set.
  • Add tests for these above.

Motivation

Thank you for this great convenient tool.

But I would be happier if I can use cd - and cd .. as they were before I introduced enhancd.
So, I tried a hack to make these args configurable.

Though this change is for myself, I would be happy if you like it.

P.S.

And thank you for using "shove" for testing!

@b4b4r07

This comment has been minimized.

Show comment
Hide comment
@b4b4r07

b4b4r07 Jun 30, 2016

Owner

Hi, @key-amb . Thank you for your contribution and I'm so sorry for taking long to write you back.

I got it. Please wait a little because I'll try it out! Thanks.

Owner

b4b4r07 commented Jun 30, 2016

Hi, @key-amb . Thank you for your contribution and I'm so sorry for taking long to write you back.

I got it. Please wait a little because I'll try it out! Thanks.

@b4b4r07 b4b4r07 merged commit bf068c3 into b4b4r07:master Aug 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@b4b4r07

This comment has been minimized.

Show comment
Hide comment
@b4b4r07

b4b4r07 Aug 29, 2016

Owner

Awesome! Thanks @key-amb and sorry for late reply.

Owner

b4b4r07 commented Aug 29, 2016

Awesome! Thanks @key-amb and sorry for late reply.

@key-amb key-amb deleted the key-amb:feature/configure-subcommands branch Aug 29, 2016

@key-amb

This comment has been minimized.

Show comment
Hide comment
@key-amb

key-amb Aug 29, 2016

Contributor

Thanks!

Contributor

key-amb commented Aug 29, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment