Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger SPI #208

Closed
michbarsinai opened this issue Apr 24, 2023 · 0 comments · Fixed by #212
Closed

logger SPI #208

michbarsinai opened this issue Apr 24, 2023 · 0 comments · Fixed by #212
Milestone

Comments

@michbarsinai
Copy link
Member

Currently BPjs' logger is printing to the stream it has. This is OK for embedding in other systems, since the host can provide its own stream. However, the log level is lost since and the host has no efficient way of knowing if a printed message was INFO, FINE, or WARN.

We need to break the current logger into an interface and a default implementation. Then, allow client code to provide its own logger.

@michbarsinai michbarsinai added this to the PVG-1 milestone Apr 24, 2023
@maor226 maor226 linked a pull request May 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant