Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog app - creating a data model #1

Merged
merged 15 commits into from
Jan 16, 2023
Merged

Blog app - creating a data model #1

merged 15 commits into from
Jan 16, 2023

Conversation

Baayeh
Copy link
Owner

@Baayeh Baayeh commented Jan 16, 2023

Create Schema from Migrations

In this PR, I completed the following tasks:

  • Created a rails app called blog_app
  • Setup Postgres database for the app
  • Built the schema for the app using migrations
  • Included foreign keys with their indexes

Copy link

@codecaiine codecaiine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Baayeh,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Great data model implementation ✔️
  • No linters errors ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me (@codecaiine) in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Baayeh Baayeh merged commit 013e274 into dev Jan 16, 2023
@Baayeh Baayeh deleted the data-model branch January 16, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants