Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morning session peer to peer code review #4

Closed
apt2tell opened this issue Sep 30, 2022 · 1 comment
Closed

Morning session peer to peer code review #4

apt2tell opened this issue Sep 30, 2022 · 1 comment

Comments

@apt2tell
Copy link

To Do List: Code Review

Nice job 👍 Clean code. Excellent!

We have a few suggestions to make here:

  • Your code is neat, but we would rather suggest that you should as much as possible avoid the use of styles in html file. It would rather be better having all styles in style.css
  • We also suggest that the use of prettier would improve the code formatting a lot more
@Baayeh Baayeh closed this as completed Oct 3, 2022
@Baayeh
Copy link
Owner

Baayeh commented Oct 3, 2022

Thanks for the suggestion 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Baayeh @apt2tell