Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and Remove Feature #2

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Add and Remove Feature #2

merged 4 commits into from
Sep 29, 2022

Conversation

Baayeh
Copy link
Owner

@Baayeh Baayeh commented Sep 28, 2022

I completed the following tasks in this milestone:

  • I created three modules:

    1. TodoClass - to handle the Todo class
    2. DOMElements - to handle access to all DOM elements.
    3. Methods - to handle all functions and methods of the application
  • Created a collection to hold all the todo items

  • Added a method to add a todo item to the collection

  • Added a method to store the collection in the localStorage

  • Added a method to remove an item from the collection and update the collection

  • Added a method to edit a todo item and update the collection

Copy link

@AmaduKamara AmaduKamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: APPROVED 🟢🟢🟢

Hi @Baayeh,

You did great on this milestone. Keep it up 💪💪💪
Your project is complete!

Highlights:

✅ You used Gitflow correctly
✅ Linter checks passed
✅ Good commit messages 👍
✅ Good descriptive PR 👍
✅ Code is structured well, add, remove, and edit functionalities work fine as expected 👍

There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Baayeh Baayeh merged commit 9a33902 into main Sep 29, 2022
@Baayeh Baayeh deleted the add-remove-todo branch September 29, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants