feat: add with-temp-dir macro #37
Conversation
The macro takes a sequence of binding-name, options pairs. The body is evaluated with binding-name bound to a java.io.File path to a temporary directory, created by passing options to create-temp-dir. The temporary directories are deleted with delete-tree in the reverse of the order in which they were declared. Options are as for create-temp-dir. Adds an exported clj-kondo config for the macro.
src/babashka/fs.cljc
Outdated
| (defmacro with-temp-dir | ||
| "bindings [binding-name options ...] | ||
|
|
||
| Evaluate body with binding-name bound to a java.io.File path to a |
There was a problem hiding this comment.
the binding-name is bound to a file. in babashka.fs this is either a nio Path or java io File. You should not rely on this detail but if you care specifically, use fs/file or fs/path to convert between the two. So I would just call this "file" without specifying the type.
src/babashka/fs.cljc
Outdated
| of the order in which they were declared. | ||
|
|
||
| Options is a map with the keys as for create-temp-dir." | ||
| {:arglists '[[[binding-name options ...] & body]]} |
There was a problem hiding this comment.
What is the practical use case for multiple tmp dirs? Just curious about this.
There was a problem hiding this comment.
I don't think I've ever actually used that feature. Removing would simplify the code. I'll do that.
src/babashka/fs.cljc
Outdated
|
|
||
| (symbol? (bindings 0)) | ||
| (with-temp-dir-fn (subvec bindings 0 2) | ||
| (if-let [more-bindings (not-empty (subvec bindings 2))] |
There was a problem hiding this comment.
I believe not-empty can just be seq here?
EDIT: oh, right, you want to preserve the type.
|
Added a few questions/comments. Otherwise, this looks really good! |
|
I also wasn't sure if the path to the edm config was correct - |
- Remove multiple dir support - Doc string
|
@hugoduncan Just |
|
Path changed |
The macro takes a sequence of binding-name, options pairs.
The body is evaluated with binding-name bound to a java.io.File path to
a temporary directory, created by passing options to create-temp-dir.
The temporary directories are deleted with delete-tree in the reverse
of the order in which they were declared.
Options are as for create-temp-dir.
Adds an exported clj-kondo config for the macro.