Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement in-ns as function rather than built-in #790

Open
borkdude opened this issue Aug 19, 2022 · 2 comments
Open

implement in-ns as function rather than built-in #790

borkdude opened this issue Aug 19, 2022 · 2 comments

Comments

@borkdude
Copy link
Collaborator

No description provided.

@SignSpice
Copy link
Contributor

Good Afternoon!
I'm interested in this feature, in particular for use with RCF.

I'm happy to help with it if I can. Although at the moment I would not be sure where to start.

@borkdude
Copy link
Collaborator Author

Thanks for your interest.

This should be removed:

sci/src/sci/impl/analyzer.cljc

Lines 1358 to 1364 in 09b269c

(defn analyze-in-ns [ctx expr]
(let [ns-expr (analyze ctx (second expr))]
(sci.impl.types/->Node
(let [ns-sym (types/eval ns-expr ctx bindings)]
(set-namespace! ctx ns-sym nil)
nil)
nil)))

in-ns (analyze-in-ns ctx expr))

And then we should add a function in sci.impl.namespaces. There are many similar sci-ns-* functions in there that might give you ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants