Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Remove comment attachment #707

Closed
kaicataldo opened this issue Oct 28, 2018 · 0 comments · Fixed by #736
Closed

Remove comment attachment #707

kaicataldo opened this issue Oct 28, 2018 · 0 comments · Fixed by #736

Comments

@kaicataldo
Copy link
Member

kaicataldo commented Oct 28, 2018

ESLint no longer uses attached comments in the AST and so babel-eslint doing comment attachment is now work that is just thrown away. I'd like to propose removing the behavior entirely (but still keeping the top-level comments array that ESLint does require to calculate comment location internally.

I opened a similar issue for the default parser, Espree.

Note that this is a breaking change, but it seems unlikely that any other project will really be affected by it since the purpose of this project is to provide compatibility with ESLint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant