Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from "master" branch to "main" #11715

Merged
merged 10 commits into from
Jun 19, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 12, 2020

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
License MIT

As per discussion on Slack, this PR is migrating from master to main.

  1. We should not delete the master because it would cause problems to all the existing PRs.
  2. When merging an existing PR, we just need to change the target branch from master to main
  3. We can lock master so that we don't accidentally merge PRs into it.

The REPL should already work but it doesn't. I'll investigate why. Unrelated - babel/website#2277

While I was doing this, I also enabled test262 on the next-8-* branches.

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 12, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23937/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8bf0b7f:

Sandbox Source
currying-moon-y3s7p Configuration
hardcore-edison-52n8u Configuration

@nicolo-ribaudo
Copy link
Member Author

Repl is fixed by babel/website#2277, and it's unrelated to this PR.

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review June 13, 2020 20:28
@@ -137,7 +137,7 @@ To enable the Node.js debugger added in v6.3.0, set the `TEST_DEBUG` environment
$ TEST_DEBUG=true make test
```

You can combine `TEST_DEBUG` with `TEST_GREP` or `TEST_ONLY` to debug a subset of tests. If you plan to stay long in the debugger (which you'll likely do!), you may increase the test timeout by editing [test/mocha.opts](https://github.com/babel/babel/blob/master/test/mocha.opts).
You can combine `TEST_DEBUG` with `TEST_GREP` or `TEST_ONLY` to debug a subset of tests. If you plan to stay long in the debugger (which you'll likely do!), you may increase the test timeout by editing [test/testSetupFile.js](https://github.com/babel/babel/blob/main/test/testSetupFile.js).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link was wrong

@@ -13,7 +13,7 @@
"bugs": {
"url": "https://github.com/babel/babel/issues"
},
"homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-parser",
"homepage": "https://babeljs.io/",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we are doing with almost all the other packages

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also replace babel/babel/blob/master by babel/babel/blob/main in ./docs/**/*.md of babel-website.

@babel babel deleted a comment from funny-falcon Jun 16, 2020
@JLHwung JLHwung merged commit 79e5759 into babel:main Jun 19, 2020
JLHwung pushed a commit that referenced this pull request Jun 19, 2020
* Remove dead link

* Use consistent "homepage" url in package.json

* Update md links

* Update comment link in parser d.ts

* Add comment in gitpod config

* Update circleci config

* Update PULL_REQUEST_TEMPLATE

* Update badges

* Trigger CI

* Update 404 link
@nicolo-ribaudo nicolo-ribaudo deleted the migrate-master-to-main branch June 20, 2020 00:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants