Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repl] Get the correct job id from CircleCI #2277

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Conversation

nicolo-ribaudo
Copy link
Member

The repl for master is currently not loading: try opening https://babeljs.io/repl/build/master in an incognito window.

This is because the repl always gets the last CI build from Circle CI. However, it could happen that it's not build-standalone but e2e-* (https://circleci.com/api/v1.1/project/github/babel/babel/tree/master?filter=successful&limit=1): in that case, it won't find the artifact.

This PR fixes it by loading the last 10 builds and then finding the correct one.

@netlify
Copy link

netlify bot commented Jun 13, 2020

Deploy preview for babel ready!

Built with commit 87e1964

https://deploy-preview-2277--babel.netlify.app

@existentialism existentialism merged commit de8ca41 into master Jun 15, 2020
@existentialism existentialism deleted the circleci-job-repl branch June 15, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants