-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add ImportExpression visitorKeys #11932
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27037/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 665011e:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 69c9f1e:
|
@@ -569,7 +569,7 @@ describe("Babel and Espree", () => { | |||
|
|||
it("Dynamic Import", () => { | |||
parseAndAssertSame(` | |||
const a = import('a'); | |||
const a = import(moduleName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test example is revised so that if we do not update VISITOR_KEYS
, the identifier will not be traversed and the test will fail due to mismatch AST. Note that when traversing AST we remove loc.identifierName
.
As a follow-up to #10828, this PR adds
ImportExpression
toVISITOR_KEYS
.