Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template string failing with Cannot read property 'range' of null #10904

Open
yitomok opened this issue Dec 21, 2019 · 3 comments
Open

Template string failing with Cannot read property 'range' of null #10904

yitomok opened this issue Dec 21, 2019 · 3 comments
Labels

Comments

@yitomok
Copy link

@yitomok yitomok commented Dec 21, 2019

It throws error when dynamic import, template literal inline and rule template-curly-spacing as follow:

Tested on:

babel-eslint@10.0.3 (with @babel/parser@7.7.7)
eslint@6.7.2

Sample code:

import(`${'package.json'}`)

.eslintrc.json

{
  "parser": "babel-eslint",
  "rules": {
    "template-curly-spacing": ["error", "never"]
  }
}

The problem is coming from @babel/parser@7.7.7, which added ImportExpression.

Originally posted by @yitomok in babel/babel-eslint#799 (comment)

@babel-bot

This comment has been minimized.

Copy link
Collaborator

@babel-bot babel-bot commented Dec 21, 2019

Hey @yitomok! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@kaicataldo

This comment has been minimized.

Copy link
Member

@kaicataldo kaicataldo commented Dec 23, 2019

I think this should be fixed by #10828, but will have to verify.

@kaicataldo

This comment has been minimized.

Copy link
Member

@kaicataldo kaicataldo commented Dec 23, 2019

Added to #10752 so I don't forget to verify this when I start going through rules.

@clarkdo clarkdo mentioned this issue Dec 30, 2019
0 of 1 task complete
mahdipourziaei-binary added a commit to mahdipourziaei-binary/deriv-app that referenced this issue Jan 2, 2020
@pi0 pi0 mentioned this issue Jan 14, 2020
0 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.