Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #3217 and add tests #3245

Merged
merged 2 commits into from Jan 7, 2016
Merged

Revert #3217 and add tests #3245

merged 2 commits into from Jan 7, 2016

Conversation

amasad
Copy link
Member

@amasad amasad commented Jan 7, 2016

Couldn't figure out how to fix the issue, a lot of other tests started breaking (parenthesizing something twice).

@hzoo now that we have those tests you can revisit after we push a hotfix
fixes https://phabricator.babeljs.io/T6927 and https://phabricator.babeljs.io/T6926

@amasad
Revert "babel-types: add Binary alias to AssignmentExpression d…
6abee42 
…efinition (fixes T6887)"

This was causing problems with parenthesizing assignment expression
This reverts commit b5cf529.
@amasad
add assignment expression parentheses test
ec983b2
@amasad amasad mentioned this pull request Jan 7, 2016
Closed
@codecov-io
Copy link

Current coverage is 85.09%

Merging #3245 into master will decrease coverage by -0.11% as of ee53010

@@            master   #3245   diff @@
======================================
  Files          215     215       
  Stmts        15697   15697       
  Branches      3359    3359       
  Methods          0       0       
======================================
- Hit          13375   13358    -17
- Partial        675     695    +20
+ Missed        1647    1644     -3

Review entire Coverage Diff as of ee53010

Powered by Codecov. Updated on successful CI builds.

amasad added a commit that referenced this pull request Jan 7, 2016
@amasad
Merge pull request #3245 from babel/assig-parenth
c415c00 
Revert #3217 and add tests
@amasad amasad merged commit c415c00 into master Jan 7, 2016
@amasad amasad deleted the assig-parenth branch January 7, 2016 00:24
@ide ide mentioned this pull request Jan 7, 2016
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amasad @codecov-io