Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-types: add Binary alias to AssignmentExpression definitio… #3217

Merged
merged 1 commit into from
Jan 5, 2016
Merged

babel-types: add Binary alias to AssignmentExpression definitio… #3217

merged 1 commit into from
Jan 5, 2016

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Dec 27, 2015

@codecov-io
Copy link

Current coverage is 85.12%

Merging #3217 into master will decrease coverage by -0.02% as of 1476ebb

@@            master   #3217   diff @@
======================================
  Files          215     215       
  Stmts        15662   15662       
  Branches      3353    3353       
  Methods          0       0       
======================================
- Hit          13335   13333     -2
+ Partial        683     681     -2
- Missed        1644    1648     +4

Review entire Coverage Diff as of 1476ebb

Powered by Codecov. Updated on successful CI builds.

@sebmck
Copy link
Contributor

sebmck commented Dec 31, 2015

Failing tests.

@hzoo
Copy link
Member Author

hzoo commented Jan 1, 2016

Tests pass now.

Seems like adding Binary causes parentheses to be added where it isn't needed in certain cases and for it to be removed when the node.left is an ObjectPattern. Although I'm not sure if this is the right way to do this.

amasad added a commit that referenced this pull request Jan 5, 2016
@amasad
Merge pull request #3217 from babel/hzoo-patch-1
06545e6 
`babel-types`: add `Binary` alias to `AssignmentExpression` definitio…
@amasad amasad merged commit 06545e6 into master Jan 5, 2016
@amasad amasad deleted the hzoo-patch-1 branch January 5, 2016 22:26
@hzoo hzoo mentioned this pull request Jan 6, 2016
Closed
amasad added a commit that referenced this pull request Jan 7, 2016
@amasad
Merge pull request #3245 from babel/assig-parenth
c415c00 
Revert #3217 and add tests
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzoo @codecov-io @sebmck @amasad