don't remove impure reachable parts of logical expressions #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| path.replaceWith(node.left); | ||
| } | ||
| } else if (node.operator === "||") { | ||
| if (left.evaluateTruthy() === false && left.isPure()) { |
There was a problem hiding this comment.
whoops, that's not right :P
|
I think I fixed my logic mistakes. I'm not entirely sure if all the branches I put in are necessary or if |
kangax
reviewed
Sep 14, 2016
| expect(transform(source)).toBe(source); | ||
|
|
||
| source = unpad(` | ||
| alert(func() || true); |
There was a problem hiding this comment.
Shouldn't we remove true from the RHS here since it has no side effects?
There was a problem hiding this comment.
a = foo() || true. a should be true if foo() is truthy.
There was a problem hiding this comment.
if func() is falsy, func() || true would still evaluate to true, so the RHS is significant for the final value
kangax
approved these changes
Sep 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at dealing with #159.
Impure statements like function calls were removed from the right-hand side of
&&expressions if they were inferred to return a falsy value (e.g. when using thevoidoperator).This patch checks if the thing to be removed is pure. There's a lot more manual checking involved but it also simplifies more stuff.