Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add node 4,7, drop 5 #229

Merged
merged 3 commits into from
Oct 30, 2016
Merged

add node 4,7, drop 5 #229

merged 3 commits into from
Oct 30, 2016

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Oct 27, 2016

No description provided.

@boopathi
Copy link
Member

I rebased master so CI could pass.

@boopathi
Copy link
Member

looks like node4 fails due to npm 2 ? eslint-plugin-flow-vars not found ?

@hzoo
Copy link
Member Author

hzoo commented Oct 27, 2016

Ah yeah - we can pr to make eslint only run in lastest node

@hzoo
Copy link
Member Author

hzoo commented Oct 28, 2016

works!

@boopathi boopathi merged commit 371a7e2 into master Oct 30, 2016
@boopathi boopathi deleted the hzoo-patch-1 branch October 30, 2016 19:03
@hzoo hzoo added the Tag: Internal Pull Request changing project internals - code that is NOT published label Oct 31, 2016
kangax pushed a commit that referenced this pull request Nov 2, 2016
@hzoo @kangax
add node 4,7, drop 5 (#229)
b3048f4 
* add node 4,7, drop 5

* lint in node

* remove lint for every env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boopathi boopathi boopathi approved these changes

Assignees
No one assigned
Labels
Tag: Internal Pull Request changing project internals - code that is NOT published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzoo @boopathi