-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak simpify README #320
Tweak simpify README #320
Conversation
else b(); | ||
} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6320550
to
d75e595
Compare
@@ -2,9 +2,10 @@ | |||
|
|||
This plugin will transform code in mainly two ways: | |||
|
|||
1. Reduce as much statements as possible into expressions | |||
1\. Reduce as much statements as possible into expressions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this required ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is something that needs to be fixed on the website then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. It's not in the readme on github as well. Cool ... Then we can simply use unordered lists instead of ordered ... Numbering isn't important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, can revert that until we get a more robust fix in place. Just note that this isn't isolated to just the website, the numbering is off on npm and GitHub) due to the code block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even headings, maybe ? what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't isolated to just the website
Yeah. Noticed it just now. do you think making it a heading would be better ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's definitely another option... howabout:
> Simplifies code for minification by reducing statements into expressions and making expressions and uniform where possible.
## Example
### Reduce statement into expression:
**In**
// code example
**Out**
// code example
### Make expression as uniform as possible for better compressibility:
**In**
// code example
**Out**
// code example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
dedbf05
to
1a982bd
Compare
@boopathi updated! /cc: @xtuc @geordidearns |
@@ -1,10 +1,13 @@ | |||
# babel-plugin-minify-simplify | |||
|
|||
This plugin will transform code in mainly two ways: | |||
> Simplifies code for minification by reducing statements into expressions and making expressions and uniform where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- and making expressions and uniform
+ and making expressions uniform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
1a982bd
to
92e1014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@xtuc @geordidearns. do you have any comments before I merge this ?
Nice work, LGTM 👍 |
Adds line break in between examples (babel/website#1029) and fixes numbering.