Fix remove console.* statements #421
Conversation
boopathi
commented
Feb 12, 2017
boopathi
commented
- (Fix SyntaxError after transform-remove-console #374)
- (Fix Account for removal of consequent inside ternary for no-console plugin. Fixes #374 #375)
|
/cc @DrewML |
|
👍 |
|
Hi! I'm a first time contributor to babili, and had a few questions/comments about this pull request!
Thanks! |
|
Wow @mikesherov's here 😄 |
| }, | ||
| }; | ||
|
|
||
| function isConsole(memberExpr) { |
There was a problem hiding this comment.
Seems this needs to check for console.log.call and console.log.apply.
There was a problem hiding this comment.
And the test needs to check both a = console.log.call and console.log.call()
|
@mikesherov this will change it(not transforming function to arrow. But use arrow directly by checking if the target the user intended supports arrow) - #428. |
|
Got it. |
|
Added |
| MemberExpression: { | ||
| exit(path) { | ||
| if (!isConsole(path)) return; | ||
| if (!path.parentPath.isMemberExpression()) { |
There was a problem hiding this comment.
Is this clearer as:
if (isConsole(path) && !path.parentPath.isMemberExpression()) {
| exit(path) { | ||
| if (isConsole(path) && !path.parentPath.isMemberExpression()) { | ||
| path.replaceWith(createNoop()); | ||
| } |
There was a problem hiding this comment.
It looks not work with console.err = xx (React Native have similar usage), maybe we can just parentPath.remove() if path key is left and parentPath is assignment expression?
There was a problem hiding this comment.
Interesting, So, I would assume it to be replaced like this -
// in
console.foo = foo;
// out
console.foo = function () {}; which looks like the right thing to do. because it is hard to detect all usages of console.foo in code
const x = "foo";
const y = console;
y[x]();and will lead to runtime error.
