This repository has been archived by the owner on May 19, 2018. It is now read-only.
Check for duplicate named exports in exported destructuring assignments #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
force-pushed
the
check-destructured-exports
branch
2 times, most recently
from
da09c40
to
6800abc
Compare
kaicataldo
commented
Sep 24, 2016
| @@ -1,2 +1,11 @@ | |||
| export const { rhythm } = typography; | |||
| export const { TypographyStyle } = typography; | |||
| export const { foo } = bar; | |||
There was a problem hiding this comment.
These are all unique identifiers and should parse without error
There was a problem hiding this comment.
Cool was wondering about a passing test 👍
kaicataldo
force-pushed
the
check-destructured-exports
branch
from
93c3d0d
to
5152905
Compare
loganfsmyth
reviewed
Sep 26, 2016
| @@ -909,23 +909,21 @@ pp.checkExport = function (node, checkNames, isDefault) { | |||
| // Check for duplicate exports | |||
| if (isDefault) { | |||
| // Default exports | |||
| this.checkDuplicateExports(node, "default", isDefault); | |||
| this.checkDuplicateExports(node, "default"); | |||
| } else if (node.specifiers && node.specifiers.length) { | |||
| // Named exports | |||
| for (let specifier of node.specifiers) { | |||
| const name = specifier.exported.name; | |||
| if (name === "default") isDefault = true; | |||
There was a problem hiding this comment.
Looks like this isn't needed.
danez
suggested changes
Sep 26, 2016
| this.checkDeclaration(elem); | ||
| } | ||
| } else if (node.type === "ObjectProperty") { | ||
| this.checkDeclaration(node.value); |
kaicataldo
force-pushed
the
check-destructured-exports
branch
from
235398a
to
909b19a
Compare
|
Updated - thanks! |
Current coverage is 94.44% (diff: 94.11%)@@ master #144 diff @@
==========================================
Files 19 19
Lines 3111 3117 +6
Methods 327 328 +1
Messages 0 0
Branches 818 820 +2
==========================================
+ Hits 2939 2944 +5
Misses 94 94
- Partials 78 79 +1
|
danez
approved these changes
Sep 26, 2016
|
@danez I know we spoke in Slack, but wasn't sure if there is anything I need to do for the failing codecov checks? |
danez
approved these changes
Oct 4, 2016
kristofdegrave
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
…ts (babel#144) * Check for duplicate named exports in exported destructuring assignments * Refactor duplicate error reporting * Remove unnecessary check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #139. I did a little refactoring - passing
isDefaultall the way through seems unnecessary, in retrospect. Thoughts on this approach? Any cases I missed?