Breaking change: eslint-plugin-import broken 6.10.0->6.11.1

[scottnonnenberg]

Good build (6.10.0): https://circleci.com/gh/scottnonnenberg/blog/25
Bad build (6.11.1): https://circleci.com/gh/scottnonnenberg/blog/26

Seems that handling of named export statements has regressed:

SyntaxError: /home/ubuntu/blog/src/util/typography.js: `undefined` has already been exported. Exported identifiers must be unique. (22:13)
  20 | 
  21 | export const { rhythm } = typography;
> 22 | export const { TypographyStyle } = typography;
     |              ^
  23 | export const { fontSizeToMS } = typography;

Here's the whole set of the dependency changes between these two builds:

56c56
< │ │ ├─┬ optionator@0.8.1

---
> │ │ ├─┬ optionator@0.8.2
58c58
< │ │ │ ├── fast-levenshtein@1.1.4

---
> │ │ │ ├── fast-levenshtein@2.0.4
68c68
< │ │ │ ├─┬ ajv@4.7.2

---
> │ │ │ ├─┬ ajv@4.7.3
70c70
< │ │ │ ├── ajv-keywords@1.0.0

---
> │ │ │ ├── ajv-keywords@1.1.0
234c234
< │ ├── babylon@6.10.0

---
> │ ├── babylon@6.11.1
472,473c472,473
< │ │ │ ├─┬ global@4.3.0
< │ │ │ │ ├─┬ min-document@2.18.1

---
> │ │ │ ├─┬ global@4.3.1
> │ │ │ │ ├─┬ min-document@2.19.0
614c614
< │ ├── highlight.js@9.6.0

---
> │ ├── highlight.js@9.7.0
814c814
< │ │ │ ├── base64-js@1.1.2

---
> │ │ │ ├── base64-js@1.2.0
843c843
< │ │ │ ├── pbkdf2@3.0.7

---
> │ │ │ ├── pbkdf2@3.0.8
922c922
< │ │ │ ├── caniuse-db@1.0.30000534

---
> │ │ │ ├── caniuse-db@1.0.30000539
1054c1054
< │ │ │   │ ├── rsvp@3.3.1

---
> │ │ │   │ ├── rsvp@3.3.2

[hzoo]

Ok it doesn't account for destructuring @kaicataldo @danez

declaration.id.name only works for identifier

[kaicataldo]

I can try to take a look at this this weekend

[hzoo]

I think we want a hotfix now but if you want to do the actual fix later sounds good

[loganfsmyth]

Looks like this is an issue with the new export name duplicate checking, sorry about that. The new logic doesn't handle destructuring in exported variable declarations properly.

[hzoo]

https://github.com/babel/babylon/releases/tag/v6.11.2, will account for it later

[kaicataldo]

Okay, sounds good - sorry for the issues with this :/

[loganfsmyth]

@kaicataldo No problem, it happens.