This repository has been archived by the owner. It is now read-only.

Breaking change: eslint-plugin-import broken 6.10.0->6.11.1 #139

Closed
scottnonnenberg opened this Issue Sep 23, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@scottnonnenberg
Copy link

scottnonnenberg commented Sep 23, 2016

Good build (6.10.0): https://circleci.com/gh/scottnonnenberg/blog/25
Bad build (6.11.1): https://circleci.com/gh/scottnonnenberg/blog/26

Seems that handling of named export statements has regressed:

SyntaxError: /home/ubuntu/blog/src/util/typography.js: `undefined` has already been exported. Exported identifiers must be unique. (22:13)
  20 | 
  21 | export const { rhythm } = typography;
> 22 | export const { TypographyStyle } = typography;
     |              ^
  23 | export const { fontSizeToMS } = typography;
Here's the whole set of the dependency changes between these two builds:
56c56
< │ │ ├─┬ optionator@0.8.1

---
> │ │ ├─┬ optionator@0.8.2
58c58
< │ │ │ ├── fast-levenshtein@1.1.4

---
> │ │ │ ├── fast-levenshtein@2.0.4
68c68
< │ │ │ ├─┬ ajv@4.7.2

---
> │ │ │ ├─┬ ajv@4.7.3
70c70
< │ │ │ ├── ajv-keywords@1.0.0

---
> │ │ │ ├── ajv-keywords@1.1.0
234c234
< │ ├── babylon@6.10.0

---
> │ ├── babylon@6.11.1
472,473c472,473
< │ │ │ ├─┬ global@4.3.0
< │ │ │ │ ├─┬ min-document@2.18.1

---
> │ │ │ ├─┬ global@4.3.1
> │ │ │ │ ├─┬ min-document@2.19.0
614c614
< │ ├── highlight.js@9.6.0

---
> │ ├── highlight.js@9.7.0
814c814
< │ │ │ ├── base64-js@1.1.2

---
> │ │ │ ├── base64-js@1.2.0
843c843
< │ │ │ ├── pbkdf2@3.0.7

---
> │ │ │ ├── pbkdf2@3.0.8
922c922
< │ │ │ ├── caniuse-db@1.0.30000534

---
> │ │ │ ├── caniuse-db@1.0.30000539
1054c1054
< │ │ │   │ ├── rsvp@3.3.1

---
> │ │ │   │ ├── rsvp@3.3.2

scottnonnenberg added a commit to scottnonnenberg/blog that referenced this issue Sep 23, 2016

chore(deps): Pin babylon at 6.10.0; conflict with eslint-plugin-import
You know what? I hate the ~ and ^ operators!

Bug filed: babel/babylon#139
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Sep 23, 2016

Ok it doesn't account for destructuring @kaicataldo @danez

declaration.id.name only works for identifier

@hzoo hzoo added the i: bug label Sep 23, 2016

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Sep 23, 2016

I can try to take a look at this this weekend

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Sep 23, 2016

I think we want a hotfix now but if you want to do the actual fix later sounds good

@loganfsmyth

This comment has been minimized.

Copy link
Member

loganfsmyth commented Sep 23, 2016

Looks like this is an issue with the new export name duplicate checking, sorry about that. The new logic doesn't handle destructuring in exported variable declarations properly.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Sep 23, 2016

@hzoo hzoo closed this Sep 23, 2016

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Sep 23, 2016

Okay, sounds good - sorry for the issues with this :/

@loganfsmyth

This comment has been minimized.

Copy link
Member

loganfsmyth commented Sep 23, 2016

@kaicataldo No problem, it happens.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.