Use rollup for bundling to speed up startup time #190

DrewML · 2016-10-16T19:33:56Z

This closes #181.

Copy/pasting the example I posted in that issue:

Test case

const babylon = require('babylon');
const ast = babylon.parse('var foo = "lol";');

Without bundling

With bundling

With that test case, there was a ~95ms savings by removing the need for node to build/traverse the dependency graph.

As noted in that thread, this requires (for now) dropping npm run watch due to bugs in rollup-watch. Would like to hear feedback from other contributors to determine if this is going to severely impact anyone's workflow.

DrewML · 2016-10-16T19:34:51Z

package.json

@@ -29,13 +29,16 @@
    "flow-bin": "^0.33.0",
    "lodash": "^4.15.0",
    "nyc": "^8.1.0",
+    "rollup": "^0.36.3",
+    "rollup-plugin-babel": "^2.6.1",
+    "rollup-plugin-node-resolve": "^2.0.0",


This is required to be able to import an index file without having to explicitly list ./foo/index.

DrewML · 2016-10-16T19:36:43Z

src/parser/index.js

      if (!pluginMap[name]) {
        pluginMap[name] = true;

-        let plugin = exports.plugins[name];
+        let plugin = plugins[name];


I had to rename the plugins identifier in the argument list for loadPlugins, because it was shadowing the identifier of the same name at the top of the file. The current code is relying on the way the module eventually gets compiled to cjs, but this doesn't work now that we're bundling.

DrewML · 2016-10-16T19:52:40Z

Hmm. Apparently rollup only supports node 0.12.x and up. So our output bundle would work on 0.10, but we can't execute the build in Travis for 0.10 (without using something like babel-register for that version).

Thoughts?

hzoo · 2016-10-17T14:28:47Z

We could just not run rollup in node 0.10 and do what we were doing before? We should be able to run the tests with/without rollup right? (might be painful)

DrewML · 2016-10-17T15:09:26Z

We should be able to run the tests with/without rollup right? (might be painful)

My biggest concern there is that, Rollup could theoretically generate a bundle that wouldn't work on 0.10.x, but we wouldn't know if we didn't test the bundle itself.

I did have a thought, though. nvm is available on Travis containers. I could have it setup so, for 0.10/0.12, we run the rollup build in node 4, then nvm use before the tests run. I'll give it a shot later tonight

wtgtybhertgeghgtwtg · 2016-10-19T13:26:26Z

I doubt this is a feasible suggestion, but since node is dropping support for 0.10 at the end of the month, maybe you could bump Babylon to 7 and make it for node 0.12 and up? Alternatively, for node 4 and up, since node drops support for 0.12 at the end of the year.

Although, bumping the minimum node version to 4 seems to be on Babel's Next Major milestone.

hzoo · 2016-10-21T14:58:54Z

We can just use node 6 to build with rollup and then test on the rest?

danez · 2016-10-21T14:59:51Z

agree, maybe even the latest node version

edit: Uppps wrong button

DrewML · 2016-10-21T15:04:07Z

Cool - I'll push updates to the PR this weekend to build with node latest, then run tests on the target node version

DrewML · 2016-10-23T06:43:31Z

@hzoo @danez Switched things up in travis so builds run in latest node, and then tests are executed in the proper node version for that test run.

Can verify this in the Travis build logs:

hzoo · 2016-10-24T04:00:16Z

package.json

    "coverage": "nyc report --reporter=json && codecov -f coverage/coverage-final.json",
    "lint": "eslint src bin",
    "flow": "flow",
    "prepublish": "cross-env BABEL_ENV=production npm run build",
    "preversion": "npm run test && npm run changelog",
    "test": "npm run lint && npm run flow && npm run build && npm run test-only",
    "test-only": "ava test",
-    "test-ci": "cross-env BABEL_ENV=test npm run build && nyc npm run test-only",
-    "watch": "babel src --out-dir lib --watch",


do we have to remove watch if it doesn't need to use rollup?

Hmm, you bring up a good point. I just noticed that I didn't change the test-only command to run a build first, so technically the code you test against locally isn't 1:1 with the code tested in CI (babel-ified code locally, vs rollup output in CI). Thoughts?

Not sure - I don't think we do in Babel either?

Ha, that's a good point. We could leave it in, and then, if enough of us hit weirdness where things pass in CI but fail locally, we can always pull it out (or try and fix the rollup watch plugin).

I never used watch in babylon as the tests usually do a build before and the build does not take too long.

hzoo · 2016-10-25T21:44:55Z

The 'classCallCheck' Babel helper is used more than once in your code. It's strongly recommended that you use the "external-helpers" plugin or the "es2015-rollup" preset. See https://github.com/rollup/rollup-plugin-babel#configuring-babel for more information

Since we already use modules: false I guess we can add "plugins": [ "external-helpers" ]

https://gist.github.com/hzoo/6f393d0a24be191e25dee0bb894bb09e

danez

Codecoverage is broken see comments.

danez · 2016-10-25T21:58:41Z

.travis.yml

+
+before_script:
+  - 'if [ -n "${BABEL-}" ]; then make bootstrap-babel ; fi'
+  - 'npm run build'


We need to add BABEL_ENV=test here infront of the call so that babel-plugin-istanbul is used.

danez · 2016-10-25T21:59:12Z

package.json

    "coverage": "nyc report --reporter=json && codecov -f coverage/coverage-final.json",
    "lint": "eslint src bin",
    "flow": "flow",
    "prepublish": "cross-env BABEL_ENV=production npm run build",
    "preversion": "npm run test && npm run changelog",
    "test": "npm run lint && npm run flow && npm run build && npm run test-only",
    "test-only": "ava test",
-    "test-ci": "cross-env BABEL_ENV=test npm run build && nyc npm run test-only",
-    "watch": "babel src --out-dir lib --watch",
+    "test-ci": "cross-env BABEL_ENV=test nyc npm run test-only",


We can remove cross-env BABEL_ENV=test here then as it is only used for babel but babel is not run here.

danez · 2016-10-25T22:17:49Z

.travis.yml

+before_install:
+    # Rollup doesn't support node < 4.x. Switch to latest for build
+  - . $HOME/.nvm/nvm.sh
+  - nvm install stable && nvm use stable


maybe should we use nvm install --lts instead of nvm install stable stable is deprecated first of all and is now an alias for node and second it currently installs node 7 and not sure how stable that is already. Or do you think thats okay?

And btw install also automatically calls use.

hzoo · 2016-10-26T14:39:45Z

🎉

We can have a separate issue to use external-helpers - maybe it's a babel issue or a rollup one not sure but it's including the newly added asyncGenerator helper for some reason which makes it bigger https://gist.github.com/hzoo/6f393d0a24be191e25dee0bb894bb09e

Wonder how hard it would be to just dedupe it in a plugin instead

sebmck · 2016-10-26T19:30:55Z

Yay, this will also stop people doing dumb shit like this.

DrewML commented Oct 16, 2016

View reviewed changes

danez added i: enhancement Tag: Bug Fix and removed Tag: Bug Fix labels Oct 21, 2016

danez closed this Oct 21, 2016

danez reopened this Oct 21, 2016

DrewML force-pushed the rollup branch 3 times, most recently from e2fc2b4 to f4ec01d Compare October 23, 2016 06:33

Use rollup for bundling to speed up startup time

6222bc5

DrewML force-pushed the rollup branch from f4ec01d to 6222bc5 Compare October 23, 2016 06:37

hzoo reviewed Oct 24, 2016

View reviewed changes

hzoo approved these changes Oct 24, 2016

View reviewed changes

danez suggested changes Oct 25, 2016

View reviewed changes

Fix codecov

d99517e

danez reviewed Oct 25, 2016

View reviewed changes

danez approved these changes Oct 25, 2016

View reviewed changes

hzoo merged commit beb8db6 into babel:master Oct 26, 2016

DrewML deleted the rollup branch October 26, 2016 14:46

hzoo mentioned this pull request Oct 26, 2016

6.8.0 causes Uncaught ReferenceError: require is not defined errors #28

Closed

kristofdegrave pushed a commit to kristofdegrave/babylon that referenced this pull request Oct 27, 2016

Use rollup for bundling to speed up startup time (babel#190)

717cfef

jacobp100 mentioned this pull request Jan 27, 2018

All tests fail jacobp100/babel-plugin-swift-blocks#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use rollup for bundling to speed up startup time #190

Use rollup for bundling to speed up startup time #190

DrewML commented Oct 16, 2016

DrewML Oct 16, 2016

DrewML Oct 16, 2016

DrewML commented Oct 16, 2016

hzoo commented Oct 17, 2016 •

edited

Loading

DrewML commented Oct 17, 2016 •

edited

Loading

wtgtybhertgeghgtwtg commented Oct 19, 2016 •

edited

Loading

hzoo commented Oct 21, 2016

danez commented Oct 21, 2016 •

edited

Loading

DrewML commented Oct 21, 2016

DrewML commented Oct 23, 2016

hzoo Oct 24, 2016

DrewML Oct 24, 2016 •

edited

Loading

hzoo Oct 24, 2016

DrewML Oct 24, 2016

danez Oct 25, 2016

hzoo commented Oct 25, 2016 •

edited

Loading

danez left a comment

danez Oct 25, 2016 •

edited

Loading

danez Oct 25, 2016 •

edited

Loading

danez Oct 25, 2016

hzoo commented Oct 26, 2016 •

edited

Loading

sebmck commented Oct 26, 2016

Use rollup for bundling to speed up startup time #190

Use rollup for bundling to speed up startup time #190

Conversation

DrewML commented Oct 16, 2016

DrewML Oct 16, 2016

Choose a reason for hiding this comment

DrewML Oct 16, 2016

Choose a reason for hiding this comment

DrewML commented Oct 16, 2016

hzoo commented Oct 17, 2016 • edited Loading

DrewML commented Oct 17, 2016 • edited Loading

wtgtybhertgeghgtwtg commented Oct 19, 2016 • edited Loading

hzoo commented Oct 21, 2016

danez commented Oct 21, 2016 • edited Loading

DrewML commented Oct 21, 2016

DrewML commented Oct 23, 2016

hzoo Oct 24, 2016

Choose a reason for hiding this comment

DrewML Oct 24, 2016 • edited Loading

Choose a reason for hiding this comment

hzoo Oct 24, 2016

Choose a reason for hiding this comment

DrewML Oct 24, 2016

Choose a reason for hiding this comment

danez Oct 25, 2016

Choose a reason for hiding this comment

hzoo commented Oct 25, 2016 • edited Loading

danez left a comment

Choose a reason for hiding this comment

danez Oct 25, 2016 • edited Loading

Choose a reason for hiding this comment

danez Oct 25, 2016 • edited Loading

Choose a reason for hiding this comment

danez Oct 25, 2016

Choose a reason for hiding this comment

hzoo commented Oct 26, 2016 • edited Loading

sebmck commented Oct 26, 2016

hzoo commented Oct 17, 2016 •

edited

Loading

DrewML commented Oct 17, 2016 •

edited

Loading

wtgtybhertgeghgtwtg commented Oct 19, 2016 •

edited

Loading

danez commented Oct 21, 2016 •

edited

Loading

DrewML Oct 24, 2016 •

edited

Loading

hzoo commented Oct 25, 2016 •

edited

Loading

danez Oct 25, 2016 •

edited

Loading

danez Oct 25, 2016 •

edited

Loading

hzoo commented Oct 26, 2016 •

edited

Loading