-
-
Notifications
You must be signed in to change notification settings - Fork 258
Estree compatibility as plugin #277
Conversation
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=========================================
+ Coverage 97.74% 97.8% +0.05%
=========================================
Files 20 21 +1
Lines 3367 3504 +137
Branches 888 925 +37
=========================================
+ Hits 3291 3427 +136
Misses 29 29
- Partials 47 48 +1
Continue to review full report at Codecov.
|
This is great, thank you @danez! Any idea when this could be released? I'm happy to help getting this out sooner rather than later. |
I'm currently working on getting |
That is great, thank you. I will wait then 😃 |
f999b4a
to
a08bdae
Compare
This is such a big deal! |
Quick update, it already works as expected (with some minor things missing, see top) but I'm still working on doing cross-testing with flow and espree, which already revealed some issues. |
I did not commit the comparison tests between babylon with estree and espree/flow in this branch as there are a lot of mismatches. Most of them are that espree/flow cannot parse the fixture (and yes all experimental stuff excluded). I need to go through this at some point and fix on our end or report to the other parsers. The tests are in a separate branch |
This also refactors how babylon parses obj properties in general so that this logic can be more easily extended.
This ensures state.inMethod gets propagated correctly
New plugin to enable estree compatible output.
A new test runner was added, which runs all tests which are throwing tests with the estree plugin. All tests that should throw in non-estree should still throw in estree mode.