This repository has been archived by the owner. It is now read-only.

Estree compatibility as plugin #277

Merged
merged 14 commits into from Feb 12, 2017

Conversation

Projects
None yet
4 participants
@danez
Copy link
Member

danez commented Jan 10, 2017

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets Fixes #278
License MIT

New plugin to enable estree compatible output.

A new test runner was added, which runs all tests which are throwing tests with the estree plugin. All tests that should throw in non-estree should still throw in estree mode.

  • Add compare test between babylon-estree and other parser (flow and/or espree)
  • estree/estree#6

@danez danez changed the title Estree compatibility as plugin WIP: Estree compatibility as plugin Jan 10, 2017

@hzoo hzoo referenced this pull request Jan 10, 2017

Closed

Output ESTree (via a plugin) #278

@danez danez force-pushed the estree branch from 8bce9ff to bed1cde Jan 10, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 10, 2017

Codecov Report

Merging #277 into master will increase coverage by 0.05%.
The diff coverage is 99.27%.

@@            Coverage Diff            @@
##           master    #277      +/-   ##
=========================================
+ Coverage   97.74%   97.8%   +0.05%     
=========================================
  Files          20      21       +1     
  Lines        3367    3504     +137     
  Branches      888     925      +37     
=========================================
+ Hits         3291    3427     +136     
  Misses         29      29              
- Partials       47      48       +1
Impacted Files Coverage Δ
src/parser/index.js 97.95% <100%> (+0.13%)
src/parser/expression.js 97.33% <100%> (ø)
src/index.js 100% <100%> (ø)
src/plugins/estree.js 99.24% <99.24%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79dd95...1e592e0. Read the comment docs.

@fkling

This comment has been minimized.

Copy link
Contributor

fkling commented Jan 11, 2017

This is great, thank you @danez! Any idea when this could be released? I'm happy to help getting this out sooner rather than later.

@danez

This comment has been minimized.

Copy link
Member Author

danez commented Jan 11, 2017

I'm currently working on getting ObjectMethod/ObjectProperty back to Property.
That should be already everything that is left, as far as I can see right now.
So I don't want to give any estimates that I can't keep, but I think it should be ready next week.

@fkling

This comment has been minimized.

Copy link
Contributor

fkling commented Jan 11, 2017

That is great, thank you. I will wait then 😃

@danez danez force-pushed the estree branch 2 times, most recently from f999b4a to a08bdae Jan 14, 2017

@DrewML

This comment has been minimized.

Copy link
Member

DrewML commented Jan 15, 2017

This is such a big deal!

@danez

This comment has been minimized.

Copy link
Member Author

danez commented Jan 25, 2017

Quick update, it already works as expected (with some minor things missing, see top) but I'm still working on doing cross-testing with flow and espree, which already revealed some issues.

@danez danez force-pushed the estree branch from 80786ef to 4c9c1b7 Jan 27, 2017

@danez danez added Tag: New Feature and removed PR: WIP labels Jan 28, 2017

@danez danez changed the title WIP: Estree compatibility as plugin Estree compatibility as plugin Jan 28, 2017

@danez danez requested review from existentialism , loganfsmyth , danharper and hzoo Jan 28, 2017

@danez danez requested review from xtuc , motiz88 and DrewML Jan 28, 2017

@danez

This comment has been minimized.

Copy link
Member Author

danez commented Jan 28, 2017

I did not commit the comparison tests between babylon with estree and espree/flow in this branch as there are a lot of mismatches. Most of them are that espree/flow cannot parse the fixture (and yes all experimental stuff excluded). I need to go through this at some point and fix on our end or report to the other parsers.

The tests are in a separate branch estree-test

@danez danez force-pushed the estree branch from f21bf73 to 1e592e0 Feb 12, 2017

@danez danez merged commit fac1329 into master Feb 12, 2017

4 checks passed

codecov/patch 99.27% of diff hit (target 97.74%)
Details
codecov/project 97.8% (+0.05%) compared to c79dd95
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the estree branch Feb 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.