Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Add back ranges property #363

Merged
merged 4 commits into from
Mar 1, 2017
Merged

Add back ranges property #363

merged 4 commits into from
Mar 1, 2017

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Feb 18, 2017

We'll want to make this an option?

@codecov-io
Copy link

codecov-io commented Feb 18, 2017

Codecov Report

❗ No coverage uploaded for pull request base (7.0@56a92cc). Click here to learn what that means.
The diff coverage is 92.85%.

@@          Coverage Diff           @@
##             7.0     #363   +/-   ##
======================================
  Coverage       ?   96.78%           
======================================
  Files          ?       20           
  Lines          ?     3449           
  Branches       ?      915           
======================================
  Hits           ?     3338           
  Misses         ?       58           
  Partials       ?       53
Impacted Files Coverage Δ
src/options.js 100% <ø> (ø)
src/util/location.js 100% <100%> (ø)
src/plugins/flow.js 97.22% <100%> (ø)
src/parser/node.js 97.05% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a92cc...539be12. Read the comment docs.

@danez
Copy link
Member

danez commented Feb 18, 2017

Although it doesn't hurt to have it added all the time, but yes we could make it an option.

@hzoo
Copy link
Member Author

hzoo commented Feb 18, 2017

Less options the better though, dono (it is an option in acorn though, so yea)

@hzoo hzoo merged commit f1e2cca into 7.0 Mar 1, 2017
@hzoo hzoo changed the title Add back range property Add back ranges property Mar 1, 2017
@danez danez deleted the add-range-back branch March 1, 2017 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants