Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Type-check LValParser #487

Merged
merged 1 commit into from Apr 27, 2017
Merged

Type-check LValParser #487

merged 1 commit into from Apr 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 25, 2017

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? Tests pass
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

Enables type-checking in the file and annotates every method.
Requires a few forward-declarations for expression.js methods. In a few cases these could be moved to a higher class because they aren't really expression-specific (checkReservedWord, parseIdentifier, parseDecorator), but trying to keep this pull request to just type declarations.
Remove unnecessary (foo : Array<Object>) casts.

@codecov
Copy link

codecov bot commented Apr 25, 2017

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #487   +/-   ##
======================================
  Coverage    98.2%   98.2%           
======================================
  Files          21      21           
  Lines        3519    3519           
  Branches      974     974           
======================================
  Hits         3456    3456           
  Misses         24      24           
  Partials       39      39
Flag Coverage Δ
#babel 80.9% <92.3%> (ø) ⬆️
#babylon 97.04% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/parser/lval.js 97.94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68967bf...7f16d46. Read the comment docs.

@hzoo hzoo merged commit d8ff631 into babel:master Apr 27, 2017
@ghost ghost deleted the lval branch April 27, 2017 14:38
@ghost ghost mentioned this pull request May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants