Add JSX fragment syntax support #755
Conversation
There was a problem hiding this comment.
Will you update the parser to include facebook/jsx#94 here, or later after it is merged?
Also would be nice to have a test case with a JSXExpressionContainer directly inside a JSXFragment. <><div>JSXElement</div>JSXText{'JSXExpressionContainer'}</>
src/plugins/jsx/index.js
Outdated
| | ?N.JSXOpeningElement | ||
| | ?N.JSXClosingElement | ||
| | ?N.JSXOpeningFragment | ||
| | ?N.JSXClosingFragment, |
There was a problem hiding this comment.
Fragments cannot be self-closing, but it might be good to just accept any N.JSXElement to make it easier to test against arbitrary elements.
Although this is an internal use only function, so maybe it doesn't need to be extra ergonomic 🤔
src/plugins/jsx/index.js
Outdated
| | ?N.JSXClosingElement | ||
| | ?N.JSXOpeningFragment | ||
| | ?N.JSXClosingFragment, | ||
| ): boolean { |
There was a problem hiding this comment.
Does Flow support type narrowing similarly to TypeScript? If it does, the return type could be something similar to : object is N.JSXOpeningFragment | N.JSXClosingFragment.
There was a problem hiding this comment.
Not that I can find in the docs! :(
| @@ -410,8 +431,18 @@ export default (superClass: Class<Parser>): Class<Parser> => | |||
|
|
|||
| if ( | |||
| // $FlowIgnore | |||
There was a problem hiding this comment.
All these $FlowIgnore are scary...... but they were already in place 🤷♀️
| @@ -799,6 +799,9 @@ export type JSXAttribute = Node; | |||
| export type JSXOpeningElement = Node; | |||
| export type JSXClosingElement = Node; | |||
| export type JSXElement = Node; | |||
| export type JSXOpeningFragment = Node; | |||
| export type JSXClosingFragment = Node; | |||
| export type JSXFragment = Node; | |||
There was a problem hiding this comment.
Ah, that's why there are so many $FlowIgnore in the JSX parser. None of these types are written 😆
(Even if you feel inclined to, don't do it on this PR, of course)
| @@ -0,0 +1 @@ | |||
| <>Hi, I'm a string!</> | |||
There was a problem hiding this comment.
This will be very confusing for syntax highlighters for a while...
|
@Kovensky Hopefully facebook/jsx#94 will be merged soon, so that my PR for Babel/Babylon can include those changes. :) |
|
Sorry I've been inactive with this PR for a while! I'm going to open a corresponding PR for this on the Babel repository in the coming days. :) |
clemmy
force-pushed
the
add-jsx-fragment-syntax
branch
from
55a7544
to
ceb30f2
Compare
clemmy
force-pushed
the
add-jsx-fragment-syntax
branch
from
ceb30f2
to
93d77d1
Compare
|
🕺 |
This PR adds support for facebook/jsx#93.
I'm also currently working on corresponding Babel PR as well, just leaving this up here first for review, since I'm not sure if I'm abusing
$FlowIgnore. 😆UPDATE: Both PR's ready for review and Babel one can be found at babel/babel#6552