New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed annotation. #108

Merged
merged 1 commit into from Feb 4, 2017

Conversation

Projects
None yet
4 participants
@rwjblue
Copy link
Member

rwjblue commented Feb 4, 2017

Prior to this, all visualization would show would be Babel, after this change we will have Babel: <project-or-addon-name>.

Add more detailed annotation.
Prior to this, all visualization would show would be `Babel`,
after this change we will have `Babel: <project-or-addon-name>`.

@rwjblue rwjblue merged commit cc9942a into master Feb 4, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rwjblue rwjblue deleted the add-annotation branch Feb 4, 2017

@srgoldman

This comment has been minimized.

Copy link

srgoldman commented on index.js in 74c4723 Feb 7, 2017

@rwjblue This line is breaking older packages where this.parent may be undefined. We're relying on older components (no resources to update right now) and for example, ember-cli-bugsnag 0.2.0 breaks this line. Are you up for fixing this or is it up to us to submit a PR?

This comment has been minimized.

Copy link
Member Author

rwjblue replied Feb 7, 2017

Submitting a PR would definitely lead to a much faster fix, but if that is not possible please open an issue with detailed stack / info so that this isn't lost.

This comment has been minimized.

Copy link
Contributor

hsdwayne replied Feb 9, 2017

Hi @rwjblue, I've submitted a PR for this here #111

@Turbo87 Turbo87 added the internal label Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment