Support private properties in no-invalid-this (#183)

* add failing test * support ClassPrivateProperty
babel · Aug 24, 2019 · 1d10ab6 · 1d10ab6
1 parent 8409232
commit 1d10ab6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/rules/no-invalid-this.js b/rules/no-invalid-this.js
@@ -5,17 +5,18 @@ const eslint = require('eslint');
 const noInvalidThisRule = new eslint.Linter().getRules().get('no-invalid-this');
 
 module.exports = ruleComposer.filterReports(
-    noInvalidThisRule,    
+    noInvalidThisRule,
     (problem, metadata) => {
         let inClassProperty = false;
         let node = problem.node;
 
         while (node) {
-            if (node.type === "ClassProperty") {
+            if (node.type === "ClassProperty" ||
+                node.type === "ClassPrivateProperty") {
                 inClassProperty = true;
                 return;
             }
-            
+
             node = node.parent;
         }
 

diff --git a/tests/rules/no-invalid-this.js b/tests/rules/no-invalid-this.js
@@ -602,6 +602,21 @@ const patterns = [
         valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
         invalid: []
     },
+
+    // Class Private Instance Properties.
+    {
+        code: "class A {#a = this.b;};",
+        parserOptions: { ecmaVersion: 6 },
+        valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
+        invalid: []
+    },
+
+    {
+        code: "class A {#a = () => {return this.b;};};",
+        parserOptions: { ecmaVersion: 6 },
+        valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
+        invalid: []
+    },
 ];
 
 const ruleTester = new RuleTester();