This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Support private properties in no-invalid-this #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fergald
force-pushed
the
no-invalid-this-private
branch
from
016c9f5
to
a8cc1ec
Compare
|
@existentialism could you look at this PR (sorry, no idea how to find suitable reviewers but you are the most recent and voluminous contributor). |
|
I tried to add private methods to this, but I found no easy way to enable "classPrivateMethods" in the parser for the tests. |
|
Thanks! Can you merge the change? I don't have permission. |
nicolo-ribaudo
approved these changes
Aug 24, 2019
|
Thanks! |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
…bel#183) * add failing test * support ClassPrivateProperty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182
Also count
node.type === ClassPrivatePropertyas being a class property.